Skip to content

ActBlue Link Form Cleanup - #578

Open
zoe2276 wants to merge 7 commits into
Progressive-Victory:devfrom
nathan-kenmognie:dev
Open

ActBlue Link Form Cleanup#578
zoe2276 wants to merge 7 commits into
Progressive-Victory:devfrom
nathan-kenmognie:dev

Conversation

@zoe2276

@zoe2276 zoe2276 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your work! Please fill out this template as a comment on this PR and notify me when that is completed.

# (Bug|Feature|Task)/(Issue ID)

## Description

(Describe your changes to the code, and why you're making them.)

## Details

What is your discord username?

- (Answer here)

Please link to the related github issue:

- (Answer here)

Do your changes impact anything else?

- (Answer here)

Any extra notes:

- (OPTIONAL: Answer here)

Verifies the contribution before showing confirmation.
Shows lookup errors without swapping views.
Reopens the link form when the final link mutation fails.
Trims email and order ID before lookup and submission.
@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

@nathan-kenmognie is attempting to deploy a commit to the PV Team on Vercel.

A member of the Team first needs to authorize it.

@nathan-kenmognie

nathan-kenmognie commented Sep 3, 2026

Copy link
Copy Markdown

bug/521/actblue-link-form-cleanup

If you put in your order ID with spaces the link fails. Add some basic sanitization (trim) for the fields to improve user experience.

Additionally, there is no feedback for the user to know t Using the PV website on Firefox

Attempted to access the "Volunteer" page
The page did not loadheir link has failed, since the component swaps back before you get a chance to see that there is an error message

Description

Verifies the contribution before showing confirmation. Shows lookup errors without swapping views.
Reopens the link form when the final link mutation fails. Trims input values so white spaces don't wreck the whole pipeline. The separate Firefox Volunteer-page report remains unaddressed.

Details

What is your discord username?

  • Wingedwombat

Please link to the related github issue:

Do your changes impact anything else?

  • No, just handling the submission.

@zoe2276
zoe2276 requested a review from AmberLehmann September 5, 2026 01:28
@zoe2276

zoe2276 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

closes #521

@zoe2276 zoe2276 linked an issue Sep 5, 2026 that may be closed by this pull request
@zoe2276
zoe2276 marked this pull request as ready for review September 5, 2026 01:30

@AmberLehmann AmberLehmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A couple things: I think we should make it clear that the address used for shipping membership benefits to avoid members clicking confirm on the address from ActBlue which may be outdated. See image below:

Image

Also quick question: We're you able to test these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ActBlue Link Form Needs Serialization and Feedback

3 participants