Skip to content

[Bug]: ActBlue Link Form Needs Serialization and Feedback #521

Description

@zoe2276

Discord Username

ooquaria | bito

Description of the Bug

If you put in your order ID with spaces the link fails. Add some basic sanitization (trim) for the fields to improve user experience.

Additionally, there is no feedback for the user to know their link has failed, since the component swaps back before you get a chance to see that there is an error message

Steps to Reproduce

For example:

  • Link your ActBlue account with an order number prefixed (or suffixed) with a space
  • Confirm your information in the subsequent modals
  • Watch the world crumble

[Optional] Suggested Fix

We can fix the bug by:

  • .trim() the text fields in the link form and address confirmation form
  • Delay the state change until after the contribution has been confirmed to exist in ActBlue
    • Check for the existence of the contribution before even showing the information confirmation modals for optimal experience

Acceptance Criteria

A PR for this issue must:

  • Gracefully handle link errors
  • Trim whitespace from form text fields

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions