-
Notifications
You must be signed in to change notification settings - Fork 8
Removed heroicon, replaced with fa6 icons #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| import styles from './stages.module.css' | ||
| import { cn } from '@/util' | ||
| import { useInit } from '@/util/hooks' | ||
| import { CalendarIcon } from '@heroicons/react/24/solid' | ||
| import { FaCalendar } from 'react-icons/fa6' | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will switch now, thanks for the feedback |
||
|
|
||
| export interface UnderageStageProps { | ||
| isPending: boolean | ||
|
|
@@ -13,7 +13,7 @@ export function UnderageStage({ isPending, onAgeUp }: UnderageStageProps) { | |
|
|
||
| return ( | ||
| <div className={styles.container}> | ||
| <CalendarIcon className={cn(styles.icon, styles.success)} /> | ||
| <FaCalendar className={cn(styles.icon, styles.success)} /> | ||
| <p className={styles.subtitle}> | ||
| Sorry! You have to be 18 years old or older to volunteer with | ||
| Progressive Victory. | ||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note for us: no uses of this one to validate against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may wanna check out the styles on this one; the other use of this icon is fine but this one seems a little off
before:

after:
