Removed heroicon, replaced with fa6 icons - #577
Conversation
Switched to fa6 icons wherever heroicons were used previously.
|
@notrobot23 is attempting to deploy a commit to the PV Team on Vercel. A member of the Team first needs to authorize it. |
[Chore]: Deprecate heroicons/#526DescriptionRemoved all icons on the website that were from the hero icon package, and replaced each icon with a reasonable fa6-sourced equivalent. Removed the Heroicons package as requested. DetailsWhat is your discord username? Please link to the related github issue: No |
zoe2276
left a comment
zoe2276
left a comment
There was a problem hiding this comment.
i can't approve this because it's mine ): but yeah it looks good, a lot of the icons are much thicker than the heroicons variants. if you don't mind, can you add some more side-by-sides? specifically for the tweet card, cake, calendar, and plus/minus icons? those ones are the ones i noticed the biggest difference on and i think benj needs to sign off on those changes directly.
| </Suspense> | ||
| <div className={styles.footer}> | ||
| <InformationCircleIcon className={styles.infoIcon} /> | ||
| <FaCircleInfo className={styles.infoIcon} /> |
There was a problem hiding this comment.
you may wanna check out the styles on this one; the other use of this icon is fine but this one seems a little off
before:
after:
| import { cn } from '@/util' | ||
| import { useInit } from '@/util/hooks' | ||
| import { CalendarIcon } from '@heroicons/react/24/solid' | ||
| import { FaCalendar } from 'react-icons/fa6' |
There was a problem hiding this comment.
nit: FaRegCalendar is closer to the original
There was a problem hiding this comment.
Will switch now, thanks for the feedback
There was a problem hiding this comment.
note for us: no uses of this one to validate against
2 participants
Thank you for your work! Please fill out this template as a comment on this PR and notify me when that is completed.