Conversation
Feels wrong, but the chart seems fully fine to me, and I'm not seeing it get set normally either. But commented out because surely I am missing something and it isn't dead code
Last one I'll just comment out before just tapping out on the assumption I'm missing something
… and we were setting all three to their default values. Thus, we can remove the setState calls without any worry
…ng to Memoize ✖ 10 problems (0 errors, 10 warnings) - All `react-hooks/set-state-in-effect`
|
@LNorman8 must be a member of the PV team on Vercel to deploy. Learn more about collaboration on Vercel and other options here. |
Contributor
Author
|
Update: Changing nothing, It was building perfectly fine for me last night. And dev builds for me. But my branch no longer does. So that's frustrating |
…ere trying to Memoize" This reverts commit 0d311d7. This is the one seeming to cause the problems it seems. (hopefully I'm right and it will go back to 12 for the CI as well)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
* Feature/added mobile dontate button to main header (#435) * installed index lint plugin * Task/update eslint (#446) * fixed most linting issues * fixed header lint issue * lint fix on date range picker needs testing * fixed most of the lint issues * added contracts repo (#447) * Rebasing with dev --------- Co-authored-by: sH3llH0und <wyn@progress.win>
I do not understand how setting the url to '/volunteer' (without appending) is supposed to work. But this is the way to do it without a mutability error
…ne in here will be harder. - UpdatedUser is set in the tsx, which is why we need a new state variable. - We definitely need to do large scale refactors to reduce the complexity of our stuff (600 line function; CC34; I didn't fully read it to verify my changes)
Trying to merge dev showed that the offending section was modified, so better to just start over This reverts commit de691fd.
Change effect to top level conditional using state variables to determine Better solution than last time. If something new starts to set pendingLinkEmail, this solution will still be valid, since a truish value of pendingLinkEmail will always be modified (wrt it being reset to null at the end)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chore
Description
Due to a broken config, some errors were previously not showing up. Currently, we're simply allowing the errors on dev, but that's unsustainable. Just 3 days ago (in pr 456) a new one was introduced.
So I started to work on it. It's not done, but the rest can be slowly knocked out as those files are edited for other reasons. Or a new issue can be made to fix them (and the three other ignores that already existed).
Details
What is your discord username?
Please link to the related github issue:
Do your changes impact anything else?
Any extra notes:
should still be clean and good