Skip to content

Fix linting for the new repo (UNFINISHED) - #449

Closed
LNorman8 wants to merge 11 commits into
devfrom
package-update
Closed

LNorman8 wants to merge 11 commits into
devfrom
package-update

Conversation

@LNorman8

Copy link
Copy Markdown
Contributor

(Bug|Feature|Task)/(Issue ID)

Description

Running linting (either as pnpm lint or pnpm build) would crash due to running out of memory. I don't know what caused this, but updating all packages fixed it (updating just ESLint didn't).

However, now everything has been updated, and ESLint is mad at me for not following the new best practices. Every error that caused the compilation to not finish has been fixed, but there are still 20 errors.

Details

What is your discord username?

  • StaleReference

Please link to the related github issue:

  • N/A

Do your changes impact anything else?

  • Yes I updated every package. This affects every file that had an issue I fixed, and every file that has an issue I have yet to fix.

Any extra notes:

  • Untested, I tried my best to fix the unrecoverable issues, but I didn't spend time making sure my changes fully made sense
  • It might be better to test which package was the issue rather than go through a modernization campaign

sH3llH0und and others added 8 commits June 16, 2026 12:33
* fixed most linting issues

* fixed header lint issue

* lint fix on date range picker needs testing

* fixed most of the lint issues
* package penis update

* hhhhhhhhhhhhhhhh chmooooood

* package bullshit

* pls

* gay
✖ 20 problems (20 errors, 0 warnings)
it now is just errors that are being caught and canceling it. but turning them all into warnings would allow a build to occur (vs. before when the compilation fully failed).

✖ 20 problems (7 errors, 13 warnings)
(same 20 as last commit, but I changed `set-state-in-effect` to a warning)
@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

@LNorman8 must be a member of the PV team on Vercel to deploy.
- Click here to add @LNorman8 to the team.
- If you initiated this build, request access.

Learn more about collaboration on Vercel and other options here.

@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pv-frontpage-redux Error Error Jun 19, 2026 3:29am

Request Review

@LNorman8

Copy link
Copy Markdown
Contributor Author

Already done in dev. further work moved to #452

@LNorman8 LNorman8 closed this Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants