Skip to content

fix(replay-vision): clear abort when no framework is detected #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
talagluck wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(replay-vision): clear abort when no framework is detected #1205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3beb92
fix(replay-vision): abort with a clear message when no framework is d…
talagluck Sep 3, 2026
a6e25dd
improve(replay-vision): give the no-framework abort an actionable mes…
talagluck Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/lib/programs/replay-vision/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,19 @@ async function abortUnsupportedPlatform(
});
}

async function abortNoFrameworkDetected(): Promise<void> {
await wizardAbort({
code: ErrorCodes.DetectNoFramework,
message:
"Replay vision couldn't detect a framework here, so it has nothing " +
'to scope its scanners to.\n\n' +
"Make sure you're running this from your app's root directory " +
'(where its package.json or framework-equivalent lives), not an ' +
'empty or unrelated folder. See what replay supports at:\n' +
' https://posthog.com/docs/session-replay',
});
}

/**
* `[ABORT]` reasons the replay-vision skill emits when the run can't proceed.
* Kept in sync with the stop conditions in the skill's `description.md`
Expand Down Expand Up @@ -102,7 +115,16 @@ const DETECT_STEP: ProgramStep = {
// be the stale pre-copy object (see the warning in detect.ts).
onReady: async (ctx: ProgramReadyContext) => {
const integration = await detectFramework(ctx.session.installDir);
if (integration && !REPLAY_VISION_SUPPORTED.has(integration)) {
if (!integration) {
// Same early-abort ciPreRun does below: with nothing to key off of,
// the orchestrator's preflight can't resolve any task's mini-skill
// variants and would otherwise abort later with a misleading "failed
// to download" error. Fail here instead, with a message that names
// the actual problem and what to do about it.
await abortNoFrameworkDetected();
return;
}
if (!REPLAY_VISION_SUPPORTED.has(integration)) {
await abortUnsupportedPlatform(integration);
return;
}
Expand Down