fix(replay-vision): clear abort when no framework is detected - #1205
Open
talagluck wants to merge 2 commits into
Open
fix(replay-vision): clear abort when no framework is detected#1205talagluck wants to merge 2 commits into
talagluck wants to merge 2 commits into
Conversation
…etected DETECT_STEP.onReady had no guard for the "nothing detected at all" case (only for "detected something unsupported"), so an empty repo silently fell through to a null skillId. The orchestrator's preflight then failed every mini-skill variant lookup and surfaced a generic "failed to download" abort — misleading, since nothing was actually downloaded or fetched. Mirrors the guard ciPreRun already has for the CI path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HrhaMpCxKgtFSTAgMUErin
…sage The interactive path had someone at a terminal who could act on better guidance, unlike the CI path this message was copied from. Match the tone of the neighboring abortUnsupportedPlatform: name what's missing, say what to do about it, link the docs. ciPreRun keeps its terser message — that one only ever reaches a log line. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HrhaMpCxKgtFSTAgMUErin
talagluck
requested review from
TueHaulund,
arnohillen,
fasyy612 and
ksvat
and removed request for
a team
September 3, 2026 21:39
TueHaulund
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
replay-visionagainst an empty repo (or one with no recognizable framework) surfaced a misleading "Setup instructions for this project failed to download" error, becauseDETECT_STEP.onReadyhad no guard for "nothing detected at all" — only for "detected something unsupported." Withsession.skillIdleft unset, the orchestrator's preflight failed every mini-skill variant lookup and reported it as a download failure.ciPreRun(the CI/headless path) already handled this correctly by aborting early withErrorCodes.DetectNoFramework. This adds the equivalent guard to the interactive path,DETECT_STEP.onReady.Since a human is actually present on this path (unlike CI), the abort message goes further than
ciPreRun's terse one — it names the problem and what to do about it, matching the tone of the neighboringabortUnsupportedPlatformmessage:Test plan
pnpm vitest run src/lib/programs/__tests__/replay-vision.test.ts— all 6 passpnpm vitest run src/lib/programs/— all 264 pass, no regressionsnpx tsc --noEmit— no new errors introduced by this changeeslint/prettier --check— cleanpnpm try replay-vision --install-dir=<empty-dir>before/after: old code shows the misleading download-failure message, new code shows the clear framework-detection message