Skip to content

Narrow CI test suites to DuckLake and shared coverage #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benben merged 1 commit into from
Sep 7, 2026
+162 −621
Merged

Narrow CI test suites to DuckLake and shared coverage #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/bin/build-matrix-schedule-aware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,29 @@ def run_tests(_, leftover_args: list[str]):
class TestBuild(unittest.TestCase):
maxDiff = None

def test_fork_ci_keeps_ducklake_and_shared_coverage(self):
with Path(".github/schedule-config.yml").open() as stream:
configs = load_schedule_configs(stream)
matrix = build_matrix_json(configs, set(), {"event_name": "merge_group"})
modules = {module for item in matrix["include"] for module in item["modules"].split(",")}
self.assertTrue({
"plugin/trino-ducklake", "plugin/trino-posthog-catalogstore",
"core/trino-main", "core/trino-spi", "testing/trino-tests",
"plugin/trino-hive", "lib/trino-parquet", "lib/trino-filesystem-s3",
} <= modules)
self.assertFalse({
"plugin/trino-iceberg", "plugin/trino-delta-lake", "plugin/trino-postgresql",
"plugin/trino-duckdb", "lib/trino-filesystem-azure", "lib/trino-filesystem-gcs",
} & modules)
for event_name in ("pull_request", "merge_group", "repository_dispatch"):
with self.subTest(event_name=event_name):
impacted = {"plugin/trino-ducklake"}
matrix = build_matrix_json(configs, impacted, {"event_name": event_name})
self.assertEqual(
[item["modules"] for item in matrix["include"]],
["plugin/trino-ducklake"],
)

def test_load_schedule_configs(self):
configs = textwrap.dedent("""
- { modules: [a], profile: b }
Expand Down
301 changes: 102 additions & 199 deletions .github/bin/build-pt-matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,93 +11,29 @@
SUITE_DIR = Path("testing/trino-product-tests/src/test/java/io/trino/tests/product/suite")
SUITE_HELPERS = {"SuiteRunner", "SuiteTag"}

# Suites this fork does not run. SuiteHdfsImpersonation stands up seven Kerberos
# and HDFS impersonation environments, each a multi-container Hadoop stack, and
# times out waiting for one of them often enough to fail on its own. Nothing this
# fork ships reaches that code. Suites named here are left out of the matrix
# instead of being reported as unwired.
EXCLUDED_SUITES = frozenset({"SuiteHdfsImpersonation"})

SUITES = [
"SuiteMysql",
"SuitePostgresql",
"SuiteSqlServer",
"SuiteFunctions",
"SuiteTpch",
"SuiteTpcds",
"SuiteExasol",
"SuiteSnowflake",
# This fork runs DuckLake's integration tests in plugin/trino-ducklake.
# Retain product coverage of shared SQL, clients, security, fault tolerance,
# compatibility, and Parquet. The excluded suites exercise other connectors
# or storage backends. Keep exclusions explicit so new suites require review.
EXCLUDED_SUITES = frozenset({
"SuiteAllConnectorsSmoke",
"SuiteAzure",
"SuiteBlackHole",
"SuiteCassandra",
"SuiteClickhouse",
"SuiteBlackHole",
"SuiteAllConnectorsSmoke",
"SuiteIgnite",
"SuiteKafka",
"SuiteLdap",
"SuiteOauth2",
"SuiteClients",
"SuiteJdbcKerberos",
"SuiteLoki",
"SuiteRanger",
"SuiteTls",
"SuiteHiveBasic",
"SuiteHmsOnly",
"SuiteHiveStorageFormats",
"SuiteSqlCancel",
"SuiteTwoHives",
"SuiteHive4",
"SuiteHudi",
"SuiteHiveTransactional",
"SuiteAuthorization",
"SuiteFaultTolerant",
"SuiteHiveSpark",
"SuiteHiveAlluxioCaching",
"SuiteStorageFormatsDetailed",
"SuiteParquet",
"SuiteIceberg",
"SuiteIcebergVariants",
"SuiteDeltaLakeFloci",
"SuiteDeltaLakeHdfs",
"SuiteDeltaLakeOss",
"SuiteDeltaLakeAlluxioCaching",
"SuiteCompatibility",
"SuiteGcs",
"SuiteAzure",
"SuiteDeltaLakeDatabricks133",
"SuiteDeltaLakeDatabricks143",
"SuiteDeltaLakeDatabricks154",
"SuiteDeltaLakeDatabricks164",
"SuiteDeltaLakeDatabricks173",
"SuiteDeltaLakeDatabricks18",
]

ALL_SUITES = frozenset(SUITES)
ALL_CONNECTORS_SMOKE = frozenset({"SuiteAllConnectorsSmoke"})
DATABRICKS_SUITES = frozenset({
"SuiteDeltaLakeDatabricks133",
"SuiteDeltaLakeDatabricks143",
"SuiteDeltaLakeDatabricks154",
"SuiteDeltaLakeDatabricks164",
"SuiteDeltaLakeDatabricks173",
"SuiteDeltaLakeDatabricks18",
})
DELTA_LAKE_SUITES = DATABRICKS_SUITES | {
"SuiteAzure",
"SuiteDeltaLakeAlluxioCaching",
"SuiteDeltaLakeFloci",
"SuiteDeltaLakeHdfs",
"SuiteDeltaLakeOss",
"SuiteGcs",
}
HIVE_SUITES = DATABRICKS_SUITES | {
"SuiteAuthorization",
"SuiteAzure",
"SuiteClients",
"SuiteCompatibility",
"SuiteDeltaLakeFloci",
"SuiteDeltaLakeHdfs",
"SuiteDeltaLakeOss",
"SuiteExasol",
"SuiteGcs",
"SuiteHdfsImpersonation",
"SuiteHive4",
"SuiteHiveAlluxioCaching",
"SuiteHiveBasic",
Expand All @@ -108,101 +44,93 @@
"SuiteHudi",
"SuiteIceberg",
"SuiteIcebergVariants",
"SuiteParquet",
"SuiteSqlCancel",
"SuiteStorageFormatsDetailed",
"SuiteTpcds",
"SuiteTpch",
"SuiteTwoHives",
}
ICEBERG_SUITES = {
"SuiteAzure",
"SuiteCompatibility",
"SuiteDeltaLakeFloci",
"SuiteGcs",
"SuiteHiveStorageFormats",
"SuiteHmsOnly",
"SuiteIceberg",
"SuiteIcebergVariants",
"SuiteStorageFormatsDetailed",
}
JDBC_CONNECTOR_SUITES = ALL_CONNECTORS_SMOKE | {
"SuiteClickhouse",
"SuiteClients",
"SuiteExasol",
"SuiteIgnite",
"SuiteKafka",
"SuiteLoki",
"SuiteMysql",
"SuitePostgresql",
"SuiteRanger",
"SuiteSnowflake",
"SuiteSqlServer",
}
"SuiteStorageFormatsDetailed",
"SuiteTwoHives",
})

# Only modules in this map are eligible for matrix filtering. The suites include secondary
# connectors and services used by each environment, not only the connector named by the suite.
# Any impacted module absent from this map causes a full run.
SUITES = [
"SuiteFunctions",
"SuiteTpch",
"SuiteTpcds",
"SuiteLdap",
"SuiteOauth2",
"SuiteClients",
"SuiteJdbcKerberos",
"SuiteTls",
"SuiteSqlCancel",
"SuiteAuthorization",
"SuiteFaultTolerant",
"SuiteParquet",
"SuiteCompatibility",
]

ALL_SUITES = frozenset(SUITES)

# Include secondary connectors used by retained server-test environments.
# Empty mappings avoid scheduling suites for unrelated connector changes;
# unknown modules (including shared engine/libraries) still run all retained suites.
MODULE_TO_SUITES = {
# The old product-test impact analysis was connector-oriented. Keep this first pass at the
# same level: shared libraries, clients, core, and other infrastructure cause a full run.
"plugin/trino-base-jdbc": JDBC_CONNECTOR_SUITES,
"plugin/trino-blob-cache-alluxio": {
"SuiteDeltaLakeAlluxioCaching",
"SuiteHiveAlluxioCaching",
"SuiteIcebergVariants",
},
"plugin/trino-base-jdbc": {"SuiteClients"},
"plugin/trino-blob-cache-alluxio": set(),
"plugin/trino-exchange-filesystem": {"SuiteFaultTolerant"},
"plugin/trino-example-jdbc": set(),
# No product-test environment loads the DuckLake connector, so a change confined
# to it needs no product tests at all.
"plugin/trino-ducklake": set(),
"plugin/trino-spooling-filesystem": {"SuitePostgresql"},

# Connectors loaded by the all-connectors smoke environment, plus their focused suites.
"plugin/trino-bigquery": ALL_CONNECTORS_SMOKE,
"plugin/trino-blackhole": ALL_CONNECTORS_SMOKE | {"SuiteBlackHole"},
"plugin/trino-cassandra": ALL_CONNECTORS_SMOKE | {"SuiteCassandra"},
"plugin/trino-clickhouse": ALL_CONNECTORS_SMOKE | {"SuiteClickhouse"},
"plugin/trino-delta-lake": ALL_CONNECTORS_SMOKE | DELTA_LAKE_SUITES,
"plugin/trino-druid": ALL_CONNECTORS_SMOKE,
"plugin/trino-duckdb": ALL_CONNECTORS_SMOKE,
"plugin/trino-elasticsearch": ALL_CONNECTORS_SMOKE,
"plugin/trino-exasol": {"SuiteExasol"},
"plugin/trino-faker": ALL_CONNECTORS_SMOKE,
"plugin/trino-google-sheets": ALL_CONNECTORS_SMOKE,
"plugin/trino-hive": ALL_CONNECTORS_SMOKE | HIVE_SUITES,
"plugin/trino-hudi": ALL_CONNECTORS_SMOKE | {"SuiteHudi"},
"plugin/trino-iceberg": ALL_CONNECTORS_SMOKE | ICEBERG_SUITES,
"plugin/trino-ignite": ALL_CONNECTORS_SMOKE | {"SuiteIgnite"},
"plugin/trino-jmx": ALL_CONNECTORS_SMOKE | {
"SuiteDeltaLakeAlluxioCaching",
"SuiteHiveAlluxioCaching",
"SuiteIcebergVariants",
"plugin/trino-spooling-filesystem": set(),
"plugin/trino-bigquery": set(),
"plugin/trino-blackhole": set(),
"plugin/trino-cassandra": set(),
"plugin/trino-clickhouse": set(),
"plugin/trino-delta-lake": set(),
"plugin/trino-druid": set(),
"plugin/trino-duckdb": set(),
"plugin/trino-elasticsearch": set(),
"plugin/trino-exasol": set(),
"plugin/trino-faker": set(),
"plugin/trino-google-sheets": set(),
"plugin/trino-hive": {
"SuiteAuthorization",
"SuiteClients",
"SuiteCompatibility",
"SuiteParquet",
"SuiteSqlCancel",
"SuiteTpcds",
"SuiteTpch",
},
"plugin/trino-kafka": ALL_CONNECTORS_SMOKE | {"SuiteKafka"},
"plugin/trino-loki": ALL_CONNECTORS_SMOKE | {"SuiteLoki"},
"plugin/trino-mariadb": ALL_CONNECTORS_SMOKE | {"SuiteMysql", "SuiteRanger"},
"plugin/trino-memory": ALL_CONNECTORS_SMOKE | {"SuiteClients", "SuiteJdbcKerberos"},
"plugin/trino-mongodb": ALL_CONNECTORS_SMOKE,
"plugin/trino-mysql": ALL_CONNECTORS_SMOKE | {"SuiteMysql"},
"plugin/trino-opensearch": ALL_CONNECTORS_SMOKE,
"plugin/trino-oracle": ALL_CONNECTORS_SMOKE,
"plugin/trino-pinot": ALL_CONNECTORS_SMOKE,
"plugin/trino-postgresql": ALL_CONNECTORS_SMOKE | {"SuiteClients", "SuitePostgresql"},
"plugin/trino-prometheus": ALL_CONNECTORS_SMOKE,
"plugin/trino-redis": ALL_CONNECTORS_SMOKE,
"plugin/trino-redshift": ALL_CONNECTORS_SMOKE,
"plugin/trino-singlestore": ALL_CONNECTORS_SMOKE,
"plugin/trino-snowflake": ALL_CONNECTORS_SMOKE | {"SuiteSnowflake"},
"plugin/trino-sqlserver": ALL_CONNECTORS_SMOKE | {"SuiteSqlServer"},
"plugin/trino-tpcds": ALL_CONNECTORS_SMOKE | {"SuiteFunctions", "SuiteParquet", "SuiteTpcds"},
"plugin/trino-thrift": ALL_CONNECTORS_SMOKE,
"plugin/trino-thrift-api": ALL_CONNECTORS_SMOKE,
"plugin/trino-thrift-testing-server": ALL_CONNECTORS_SMOKE,

# Security and function plugins exercised outside connector-named suites.
"plugin/trino-hudi": set(),
"plugin/trino-iceberg": {"SuiteCompatibility"},
"plugin/trino-ignite": set(),
"plugin/trino-jmx": set(),
"plugin/trino-kafka": set(),
"plugin/trino-loki": set(),
"plugin/trino-mariadb": set(),
"plugin/trino-memory": {"SuiteClients", "SuiteJdbcKerberos"},
"plugin/trino-mongodb": set(),
"plugin/trino-mysql": set(),
"plugin/trino-opensearch": set(),
"plugin/trino-oracle": set(),
"plugin/trino-pinot": set(),
"plugin/trino-postgresql": {"SuiteClients"},
"plugin/trino-prometheus": set(),
"plugin/trino-redis": set(),
"plugin/trino-redshift": set(),
"plugin/trino-singlestore": set(),
"plugin/trino-snowflake": set(),
"plugin/trino-sqlserver": set(),
"plugin/trino-tpcds": {"SuiteFunctions", "SuiteParquet", "SuiteTpcds"},
"plugin/trino-thrift": set(),
"plugin/trino-thrift-api": set(),
"plugin/trino-thrift-testing-server": set(),
"plugin/trino-ldap-group-provider": {"SuiteLdap"},
"plugin/trino-password-authenticators": {"SuiteLdap"},
"plugin/trino-ranger": {"SuiteRanger"},
"plugin/trino-ranger": set(),
"plugin/trino-teradata-functions": {"SuiteFunctions"},
}

Expand Down Expand Up @@ -307,58 +235,33 @@ def validate_configuration(suite_dir=SUITE_DIR):


class TestBuildMatrix(unittest.TestCase):
def test_connector_only_change(self):
def test_unrelated_connector_changes_produce_empty_matrix(self):
for module in ("plugin/trino-mysql", "plugin/trino-kafka", "plugin/trino-delta-lake"):
with self.subTest(module=module):
self.assertEqual(build_matrix({module}), {})

def test_ducklake_has_its_own_maven_tests(self):
self.assertEqual(build_matrix({"plugin/trino-ducklake"}), {})

def test_secondary_connector_keeps_client_coverage(self):
self.assertEqual(
build_matrix({"plugin/trino-mysql"}),
{
"include": [
{"suite": "SuiteMysql"},
{"suite": "SuiteAllConnectorsSmoke"},
],
},
suites_from_matrix(build_matrix({"plugin/trino-postgresql"})),
{"SuiteClients"},
)

def test_secondary_connector(self):
def test_hive_keeps_shared_server_and_parquet_coverage(self):
self.assertEqual(
build_matrix({"plugin/trino-mariadb"}),
suites_from_matrix(build_matrix({"plugin/trino-hive"})),
{
"include": [
{"suite": "SuiteMysql"},
{"suite": "SuiteAllConnectorsSmoke"},
{"suite": "SuiteRanger"},
],
"SuiteAuthorization", "SuiteClients", "SuiteCompatibility", "SuiteParquet",
"SuiteSqlCancel", "SuiteTpcds", "SuiteTpch",
},
)

def test_shared_connector_module(self):
# GIB includes all downstream modules. trino-example-jdbc is understood to have no product suite.
impacted_modules = {
"plugin/trino-base-jdbc",
"plugin/trino-clickhouse",
"plugin/trino-druid",
"plugin/trino-duckdb",
"plugin/trino-example-jdbc",
"plugin/trino-exasol",
"plugin/trino-ignite",
"plugin/trino-mariadb",
"plugin/trino-mysql",
"plugin/trino-oracle",
"plugin/trino-postgresql",
"plugin/trino-redshift",
"plugin/trino-singlestore",
"plugin/trino-snowflake",
"plugin/trino-sqlserver",
}
matrix = build_matrix(impacted_modules)
selected_suites = suites_from_matrix(matrix)
self.assertEqual(selected_suites, JDBC_CONNECTOR_SUITES)

def test_multiple_understood_modules(self):
matrix = build_matrix({"plugin/trino-kafka", "plugin/trino-loki"})
self.assertEqual(
suites_from_matrix(matrix),
{"SuiteAllConnectorsSmoke", "SuiteKafka", "SuiteLoki"},
)
def test_excluded_suites_never_run_even_for_core_changes(self):
for impacted in (None, set(), {"core/trino-main"}, {"plugin/trino-new-connector"}):
with self.subTest(impacted=impacted):
self.assertFalse(suites_from_matrix(build_matrix(impacted)) & EXCLUDED_SUITES)

def test_core_change_runs_full_matrix(self):
self.assertEqual(build_matrix({"core/trino-main"}), build_matrix(None))
Expand Down
Loading
Loading