Repository navigation
Fix payment report users, staff password reset and dialog height - #1407
Merged
Merged
Conversation
…and-desktop-forms
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captain sales saved their creator in origin.actor_name, while payment reports read only user_name. Sale and return reports now recover the recorded creator, reject placeholder strings, safely render names and keep exports consistent. No existing sale is rewritten and later editors are never substituted for the creator.
Edit User now has an explicit Change Password option. The API persists an explicitly requested password hash and session cutoff; ordinary edits preserve the password. Supplier and Units dialogs fit their contents instead of inheriting a full-height sidebar.
Validation: 283 focused API tests, 27 report/display/export checks, form regressions, production frontend build and offscreen desktop/narrow-window layout checks. Full local checks are recorded in the follow-up document. Real customer accounts were not reset.
Sync: reports read the existing branch-scoped sales/origin data. Password changes use existing user fields and updated_date on the tenant-wide users batch lane already declared in POS, Gateway and agent. No new collections, plaintext credentials or commands are replicated. Offline tills need reconnection before updated credentials take effect. Physical cross-till delivery remains unverified.
The installed branded white-label build still needs a corrected release. This PR does not claim the user's installed app is updated. Earlier report audit and rollout limitations: docs/PAYMENT_ATTRIBUTION_EDITOR_FOLLOWUP.md.
Final integration verification: merged the current develop base, then all eight local checks passed, including 4,348 desktop tests (five skipped). The initial fix commit also passed all required GitHub checks, including the full API suite.
Installed-app audit: the configured branded stable update feed currently advertises version 1.3.0, while the installed executable is 1.9.2. It cannot deliver these fixes through the normal newer-version update check. A corrected branded installer/feed release is still required.