Repository navigation
Restore desktop tools, fix record editors and add tax reporting foundation - #1406
Merged
Merged
Conversation
Restore Desktop shortcuts and start tax reporting core
Complete responsive desktop setup and uninstall choices
sridharkalaibala
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Restores the green Desktop shortcut and desktop tool menu, including direct Kitchen Display and Kitchen sound actions. Table names now use normal text alignment in both add and edit forms.
Adds the first internal Tax & Compliance calculation boundary: exact decimal totals, timezone-aware periods, signed adjustments, duplicate/scope checks and explicit incomplete-source states. It is not yet connected to routes, screens or exports and must not be described as a usable tax report. The implementation status and remaining work are documented in docs/TAX_REPORTING_CORE.md.
Validation
Sync and rollout
No business-data writes, schema changes or new sync collections. Existing sales, receivings, expenses and branches lanes were inspected across POS, Gateway and agent definitions. No live-device sync or accountant reconciliation is claimed. Merge through develop, then main; installed desktop clients need an updated build for the UI fixes.
Record-editor follow-up
Captain payment reports now use the saved original actor instead of showing undefined. Edit User can explicitly reset passwords, while normal edits preserve them. Supplier and Units dialogs fit their content. This includes the fixes in #1407; the installed branded Windows app still requires a corrected release. Validation: 283 focused API regressions, 27 report checks, form checks, production build and offscreen layout checks passed. Desktop suite passed 4,339 tests; the documentation-only branding guard failure was corrected and all six branding checks passed. API documentation checks passed when rerun directly. Sync and rollout limits are documented in docs/PAYMENT_ATTRIBUTION_EDITOR_FOLLOWUP.md.
Final integration verification: current develop base merged without conflicts; all eight local checks passed, including 4,348 desktop tests (five skipped). The initial fix commit passed all required GitHub checks.
Installed-app audit: the configured branded stable feed still advertises 1.3.0 while the installed executable is 1.9.2. A newer correctly branded installer and matching feed metadata must be published; this PR alone does not update the user's installation.