Skip to content

Hide disabled Ask Posnic menus and use one settings Save - #1374

Merged
sridharkalaibala merged 1 commit into
developfrom
fix/settings-single-save
Oct 16, 2026
Merged

sridharkalaibala merged 1 commit into
developfrom
fix/settings-single-save

Conversation

@sridharkalaibala

@sridharkalaibala sridharkalaibala commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Ask Posnic was off, but its settings menu remained visible when another AI feature was enabled. Gate both navigation entries strictly on Ask Posnic opt-in, hide them before settings load, and avoid protected settings-tab requests while disabled. Server opt-in defaults remain off; explicitly enabled shops are preserved.

Consolidate the duplicated settings saves:

  • Core Save includes changed account sharing after the branch save succeeds, retaining the separate account-level endpoint and skipping unchanged/unloaded sharing.
  • Split Payments uses the outer Core Save. Stock, expiry, mobile inventory and payment gateways retain their existing specialised Save and hide the duplicate outer footer.
  • Tax General has one Save for tax system and default-tax settings.
  • Printer Settings has one Save for local printer/paper preferences plus branch printing options, and stops if local printer saving fails.
  • Ask Posnic AI & usage has one Save for provider configuration/secrets followed by assistant preferences. Provider failures do not submit preferences or report overall success.

Validation: frontend asset build passed. Local attribution, lint, formatting, API docs and packaging passed. The final full desktop run passed 4,294 tests and skipped five; three tests still held the old menu/duplicate-button expectations when the run started. Those expectations were updated while preserving account-scope assertions, and all 37 affected tests then passed separately. Focused save/menu/receipt/layout checks and all 57 language tests also passed. Tests preserve account-level sharing requests and device-local printer storage. No production settings were changed for verification.

Sync review: existing branch/settings write endpoints and tenant-scoped branches/settings lanes are unchanged across POS, Gateway and sync agent. Printer preferences remain device/browser-local; secrets retain their existing protected endpoint. No new fields, collections or replicated commands. Live cross-device and physical-printer verification was not performed for this UI change.

Develop first, then main. No public installer release.

@sridharkalaibala
sridharkalaibala merged commit dc49074 into develop Oct 16, 2026
11 checks passed
@github-actions github-actions Bot added the ready for QA Merged to develop and live on develop.posnic.io - anyone can test it label Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Merged to develop. Anyone can test this - you do not need write access.

Try it at https://develop.posnic.io, or run it yourself:

git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev   # then http://localhost:3000

When you have tested it, say what you did and what happened, and set
QA passed or QA failed. If you cannot set labels, just comment -
a maintainer will.

Reporting that something is broken is as useful as fixing it. It is
better found here than by a shopkeeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for QA Merged to develop and live on develop.posnic.io - anyone can test it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant