Repository navigation
Hide disabled Ask Posnic menus and use one settings Save - #1374
Merged
Merged
Conversation
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask Posnic was off, but its settings menu remained visible when another AI feature was enabled. Gate both navigation entries strictly on Ask Posnic opt-in, hide them before settings load, and avoid protected settings-tab requests while disabled. Server opt-in defaults remain off; explicitly enabled shops are preserved.
Consolidate the duplicated settings saves:
Validation: frontend asset build passed. Local attribution, lint, formatting, API docs and packaging passed. The final full desktop run passed 4,294 tests and skipped five; three tests still held the old menu/duplicate-button expectations when the run started. Those expectations were updated while preserving account-scope assertions, and all 37 affected tests then passed separately. Focused save/menu/receipt/layout checks and all 57 language tests also passed. Tests preserve account-level sharing requests and device-local printer storage. No production settings were changed for verification.
Sync review: existing branch/settings write endpoints and tenant-scoped branches/settings lanes are unchanged across POS, Gateway and sync agent. Printer preferences remain device/browser-local; secrets retain their existing protected endpoint. No new fields, collections or replicated commands. Live cross-device and physical-printer verification was not performed for this UI change.
Develop first, then main. No public installer release.