Repository navigation
Fix receipt auto-printing and receipt designer options - #1369
Merged
Merged
Conversation
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix receipt auto-printing and receipt designer options
Selecting System Default could route a Windows payment receipt to the first enumerated printer, even when it was offline. Designed thermal counter receipts could also pass an empty printer name to RAW printing. Both paths now resolve the actual Windows default and report a missing printer instead of guessing.
Receipt design changes:
Validation: 67 receipt designer tests passed, including save/reload, HTML escaping, all paper sizes, zero taxes and small non-zero taxes. Auto-print regressions passed, and actual Electron/Windows tests delivered a counter receipt and the previously failed payment receipt to the Posnic Reception capture queue. This confirms Windows delivery, not physical paper output. Local pre-push checks passed except for a newly introduced placeholder translation tag; that tag and English map were fixed, and all 124 i18n, international-language and receipt tests then passed, including the Dutch completeness check. Lint, formatting, API documentation, packaging and attribution passed. The documented push-hook escape was used after independent verification because the hook environment breaks the API docs Git comparison; GitHub required checks remain enforced.
Sync: custom footer text stays inside the existing branch receipt_designs object, validated by the shared contract. The existing tenant-scoped branches lane is present in POS, Gateway and the bundled sync agent. No new collections, commands, jobs or sync lanes are introduced. Printer selection and execution stay local. Cross-device live sync of the new footer field has not been exercised in this change; save/reload and normalization round trips are covered.
Release: merge into develop before promoting develop to main. This does not publish a desktop release; the private installer signing remains separate.