Skip to content

Show the correct global PSDK version (Fix #22)#23

Merged
AerunDev merged 2 commits intomainfrom
Show-the-correct-global-PSDK-version-(Fix-#22)
Nov 17, 2025
Merged

Show the correct global PSDK version (Fix #22)#23
AerunDev merged 2 commits intomainfrom
Show-the-correct-global-PSDK-version-(Fix-#22)

Conversation

@NuriYuri
Copy link
Copy Markdown
Contributor

Fixes the behaviour, now clones PSDK into psdk-cli configuration directory and shows PSDK version of the clone as globale version.

image

@NuriYuri NuriYuri linked an issue Nov 16, 2025 that may be closed by this pull request
3 tasks
@Aelysya
Copy link
Copy Markdown

Aelysya commented Nov 17, 2025

Testé, ça marche nickel.
J'ai juste remarqué un détail en testant:
image
Sur la 3e ligne il n'y a pas de saut de ligne entre "Searching..." et "Cloning..." vu que tu as utilisé un print, est-ce que c'est voulu ?

@NuriYuri
Copy link
Copy Markdown
Contributor Author

C'est voulu mais je pense qu'on peut corriger le comportement. Je vais modifier le print pour qu'il finisse par \r comme ça y'a pas de soucis.

Copy link
Copy Markdown
Contributor

@AerunDev AerunDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est tout bon pour moi ! 😄

Image

@AerunDev AerunDev merged commit b18705e into main Nov 17, 2025
1 check passed
@AerunDev AerunDev deleted the Show-the-correct-global-PSDK-version-(Fix-#22) branch November 17, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show the pokemonsdk version of the psdk-cli as global version in psdk-cli version

3 participants