docs(frontend): add F-075/F-041 cross-cut parenthetical to canonical row (addresses PR #31 Reviewer Issue B)#35
Open
Adiz4415 wants to merge 11 commits into
Conversation
…catalog - Restructure PROJECT/issues/CONTRACTS_ISSUES.md into a single source of truth using canonical severity/area/evidence/impact/fix/acceptance format. - Cover all 60 catalog entries from issues/contracts.md (Critical 6, High 21, Medium 24, Low 9) with stable C-### IDs. - Preserve the legacy 34-item list as Section 7 cross-reference. - Add Summary Table, Severity Counts, Resolution Tracker, Top Remediations (ship-safety order), Cross-Reference Map, and Maintenance notes. - Provide anchor points for future PR references. Closes Pi-Defi-world#12
- Catalog sources & deduping section renames the prior Deduping section and explicitly elevates PROJECT/issues/CONTRACTS_ISSUES.md (PR Pi-Defi-world#22) and PROJECT/issues/BACKEND_ISSUES.md (PR Pi-Defi-world#23) to durable long-form references; FRONTEND_ISSUES.md remains legacy pending follow-up PR. - Top 20 list gains per-item deep links to the Resolution Tracker (Section 8) of each consolidated catalog and uniformly bolds IDs. - New CHANGELOG section appended in strict reverse-chronological order (this PR refresh first, then PR Pi-Defi-world#23 backend, then PR Pi-Defi-world#22 contracts, then future frontend consolidation).
…d 11 per-item tracker pointers - Catalog sources & deduping elevates PROJECT/issues/FRONTEND_ISSUES.md to durable long-form reference (was legacy/\u2018pending follow-up\u2019), cited to PR Pi-Defi-world#25. - Top 20 list gains per-item tracker pointers for the 11 user-listed frontend items: F-001/F-002/F-005 (Critical, wallet+auth) and F-014/F-015/F-019/F-020/F-022/F-025/F-051/F-063 (top-High ship-safety), mirroring the contracts/backend pointer pattern. - CHANGELOG now in reverse-chronological order with Frontend PR Pi-Defi-world#25 at top; Master Index Refresh entry cites PR Pi-Defi-world#25 directly; legacy\n \u2018_(Future) Frontend_\u2019 placeholder retired. - F-004 (item 20) remains Critical in Top 20 without a per-item pointer\n by design \u2014 not in user\u2019s explicit 11-set; CHANGELOG documents this so\n it is addressable in a follow-up PR.
…E.MD - New nested 'Catalog consolidations' block under Project Management subsection listing PROJECT/issues/CONTRACTS_ISSUES.md (PR Pi-Defi-world#22), PROJECT/issues/BACKEND_ISSUES.md (PR Pi-Defi-world#23), and PROJECT/issues/FRONTEND_ISSUES.md (PR Pi-Defi-world#25) as durable long-form references with canonical-entry counts and severity distributions. - Corrected the adjacent pre-existing 'Known issues' line link paths from bare filenames to the working 'issues/...' form so the whole block is discoverable. - Bumped footer 'Last Updated:' from 2026-01-26 to 2026-06-20 to match the June catalog-consolidation PR envelope.
- Add F-066 \u2014 "Inconsistent loading / empty state skeletons across
pages" (Medium, frontend/components) to issues/frontend.md and the
Summary Table / Severity Counts / Resolution Tracker / Severity 5
block of PROJECT/issues/FRONTEND_ISSUES.md.
- Migrate legacy Section 7 item #49 ("Empty and loading states
inconsistent \u2014 missing Skeleton primitive") from "new \u2014 propose F-066"
to "new \u2192 adopted as F-066", preserving the legacy #49 anchor for
traceability.
- Severity distribution bumped from 5/14/23/23=65 \u2192 5/14/24/23=66.
Summary Table totals line, Severity Counts row, and Resolution
Tracker Medium cluster row all reconciled to (24 Medium).
- Cross-references: F-066 evidence path covers per-page loading.tsx /
empty.tsx under app/(app)/**.
- Add F-071 \u2014 "Toast removal delay is ~17 minutes" (Medium,
frontend/ux) to issues/frontend.md and the Summary Table / Severity
Counts / Resolution Tracker / Severity 5 block of
PROJECT/issues/FRONTEND_ISSUES.md.
- Migrate legacy Section 7 item #71 ("Toast removal delay is ~17
minutes; TOAST_REMOVE_DELAY = 1000000") from "new \u2014 propose F-071"
to "new \u2192 adopted as F-071", preserving the legacy #71 anchor for
traceability.
- Severity distribution bumped from 5/14/24/23=66 \u2192
5/14/25/23=67. Summary Table totals line, Severity Counts row, and
Resolution Tracker Medium cluster row all reconciled to (25 Medium).
- Cross-references: F-071 evidence points at
acbu-frontend/lib/toast.ts TOAST_REMOVE_DELAY constant.
- Build context: this PR builds on fix/frontend-canonical-id-f066 (PR
Pi-Defi-world#28, the F-066 migration) which is now part of the branch base.
…eout)
- Add F-076 \u2014 "Frontend request() helper has no default timeout" (High,
frontend/api) to issues/frontend.md and the Summary Table / Severity
Counts / Resolution Tracker / Severity 4 block of
PROJECT/issues/FRONTEND_ISSUES.md.
- Migrate legacy Section 7 item #76 ("API fetch has no timeout;
Frontend request() uses fetch with no default timeout") from "new
\u2014 propose F-076" to "new \u2192 adopted as F-076", preserving the
legacy #76 anchor for traceability.
- Severity distribution bumped from 5/14/25/23=67 \u2192
5/15/25/23=68. Summary Table totals line, Severity Counts High row,
and Resolution Tracker High cluster row all reconciled to (15 High).
- Cross-references: F-076 evidence points at
acbu-frontend/lib/api/client.ts request() function.
- Build context: this PR builds on fix/frontend-canonical-id-f071 (PR
Pi-Defi-world#29, the F-071 migration) which is on top of fix/frontend-canonical-id-f066
(PR Pi-Defi-world#28). Both prior PRs are part of the branch base.
- Add F-067..F-077 to issues/frontend.md in the canonical severity/area/evidence/impact/fix/acceptance format. - Mirror into PROJECT/issues/FRONTEND_ISSUES.md Summary Table, Severity Counts (Medium 25\u219228, Low 23\u219229), Resolution Tracker Medium/Low cluster rows, Section 5 Medium (3 detailed entries), Section 6 Low (6 detailed entries), and totals 68\u219277. - Migrate legacy Section 7 markers #55, #56, #68, #69, #72, #73, #74, #75, #77 from "new \u2014 propose F-XXX" to "new \u2192 adopted as F-XXX". - Final distribution: 5 Critical / 15 High / 28 Medium / 29 Low = 77. - Severity rationale: F-067/F-068/F-074 \u2192 Medium (data validation, silent-normalization privacy concern); F-069/F-070/F-072/F-073/F-075/ F-077 \u2192 Low (perf / nav-pattern / hygiene, fail-open where appropriate). - Branch builds on fix/frontend-canonical-id-f066, f071, f076 (PRs Pi-Defi-world#28, Pi-Defi-world#29, Pi-Defi-world#30) \u2014 sequential stack so each layer merges cleanly.
- Add a one-line parenthetical cross-cut note to canonical F-075 in
both `issues/frontend.md` and `PROJECT/issues/FRONTEND_ISSUES.md`
to disambiguate it from F-041:
* issues/frontend.md F-075 Evidence field:
`acbu-frontend/lib/autoFill.ts` (distinct from F-041, the
URI-length filter for savings deposits \u2014 addresses lending +
savings auto-fill)
* PROJECT/issues/FRONTEND_ISSUES.md F-075 Section 6 Evidence
field similarly updated inline.
- Goes to preserve audit provenance: legacy Section 7 item #75
originally noted \u201coverlaps the older F-041 but addresses a
different code path (lending + savings auto-fill, not URI-length
filter).\u201d Once those Section 7 markers are retired by a future
docs cleanup, the nuance was at risk of being lost; this change
surfaces it on the canonical row instead.
- Addresses reviewer Issue B from PR Pi-Defi-world#31 (F-067..F-077 batch).
- Pure documentation; no code, contract, or severity-count
changes; only a parenthetical append to the F-075 Evidence fields
in two files.
|
Warning Review limit reached
More reviews will be available in 9 minutes and 9 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation-only follow-up that addresses reviewer Issue B from PR #31: adds a one-line parenthetical cross-cut note to canonical F-075 in both catalog files so the F-041 overlap is preserved in the canonical row, not only in the Section 7 legacy marker. The note distinguishes F-075 (lending + savings auto-fill in
lib/autoFill.ts) from F-041 (URI-length filter for savings deposits).What changed
issues/frontend.md\u2014 F-075 Evidence field appended parenthetical:PROJECT/issues/FRONTEND_ISSUES.md\u2014 F-075 Section 6 Low detailed entry's inline Evidence field appended the same parenthetical.No severity changes, no canonical-ID changes, no Section 7 legacy-marker changes. Pure documentation preservation so the F-075/F-041 relationship survives any future Section 7 marker cleanup.
Why this matters
Legacy Section 7 item #75 explicitly preserved the nuance:
Once the Section 7 marker is retired by a future docs cleanup, that nuance would be lost unless it lives on the canonical row. This PR surfaces it as a parenthetical that stays with the entry forever.
Verification
issues/frontend.mdandPROJECT/issues/FRONTEND_ISSUES.mdnow reads "...acbu-frontend/lib/autoFill.ts(distinct from F-041, the URI-length filter for savings deposits \u2014 addresses lending + savings auto-fill)".Scope
Documentation-only. No code, no canonical-ID changes. One-line parenthetical in two files. Pure preservation of audit provenance.