Skip to content

docs(index): trim now-superseded forward-pointer parenthetical from PR #33 CHANGELOG entry#37

Open
Adiz4415 wants to merge 13 commits into
Pi-Defi-world:mainfrom
Adiz4415:docs/master-index-changelog-pr33-trim
Open

docs(index): trim now-superseded forward-pointer parenthetical from PR #33 CHANGELOG entry#37
Adiz4415 wants to merge 13 commits into
Pi-Defi-world:mainfrom
Adiz4415:docs/master-index-changelog-pr33-trim

Conversation

@Adiz4415

@Adiz4415 Adiz4415 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Trim the trailing "(see PR #31)." forward-pointer from a sub-bullet inside the
PR #33 CHANGELOG entry in issues/MASTER_INDEX.md. PR #31 has now closed the
backlog referenced in that line, so the forward-looking pointer is no longer
forward.

Diff scope

One file. One change. One line.

issues/MASTER_INDEX.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Line 67 (PR #33 CHANGELOG sub-bullet)

-- Outstanding (new) items in Section 7 at this snapshot: 9 (legacy #55, #56,
-   #68, #69, #72, #73, #74, #75, #77) proposed for canonical F-067–F-070 /
-   F-072–F-075 / F-077 promotion in a single batched follow-up (see PR #31).
+-  Outstanding (new) items in Section 7 at this snapshot: 9 (legacy #55, #56,
+   #68, #69, #72, #73, #74, #75, #77) proposed for canonical F-067–F-070 /
+   F-072–F-075 / F-077 promotion in a single batched follow-up.

Removed: the trailing " (see PR #31)." — a future-pointer that has now resolved.

What stayed the same

  • "Outstanding (new) items" framing preserved as historical record
  • All 9 legacy IDs (#55, #56, #68, #69, #72, #73, #74, #75, #77) preserved
  • The proposed F-067..F-077 canonical mapping preserved
  • All other CHANGELOG entries untouched (5 entries remain in strict reverse-chronological order)
  • All counts unchanged (Frontend 68 items, Total 203 etc.)
  • No other files touched

Branching

Branched off docs/master-index-changelog-pr28-30 (= PR #33 branch) so the
trim lands cleanly on top of the line it amends, without co-mingling with
PR #34 / PR #35 / PR #36.

Summary by CodeRabbit

  • Documentation
    • Restructured known issues documentation across backend, smart contracts, and frontend with improved organization and canonical issue tracking.
    • Added comprehensive issue catalogs with standardized severity levels, resolution tracking, and prioritized remediation guidance.
    • Documented 12 new frontend issues and updated overall issue catalog totals for better visibility into outstanding items.

Adiz4415 added 13 commits June 20, 2026 12:25
…catalog

- Restructure PROJECT/issues/CONTRACTS_ISSUES.md into a single source of
  truth using canonical severity/area/evidence/impact/fix/acceptance format.
- Cover all 60 catalog entries from issues/contracts.md (Critical 6, High
  21, Medium 24, Low 9) with stable C-### IDs.
- Preserve the legacy 34-item list as Section 7 cross-reference.
- Add Summary Table, Severity Counts, Resolution Tracker, Top Remediations
  (ship-safety order), Cross-Reference Map, and Maintenance notes.
- Provide anchor points for future PR references.

Closes Pi-Defi-world#12
- Catalog sources & deduping section renames the prior Deduping section
  and explicitly elevates PROJECT/issues/CONTRACTS_ISSUES.md (PR Pi-Defi-world#22) and
  PROJECT/issues/BACKEND_ISSUES.md (PR Pi-Defi-world#23) to durable long-form references;
  FRONTEND_ISSUES.md remains legacy pending follow-up PR.
- Top 20 list gains per-item deep links to the Resolution Tracker
  (Section 8) of each consolidated catalog and uniformly bolds IDs.
- New CHANGELOG section appended in strict reverse-chronological order
  (this PR refresh first, then PR Pi-Defi-world#23 backend, then PR Pi-Defi-world#22 contracts,
  then future frontend consolidation).
…d 11 per-item tracker pointers

- Catalog sources & deduping elevates PROJECT/issues/FRONTEND_ISSUES.md
  to durable long-form reference (was legacy/\u2018pending follow-up\u2019), cited
  to PR Pi-Defi-world#25.
- Top 20 list gains per-item tracker pointers for the 11 user-listed
  frontend items: F-001/F-002/F-005 (Critical, wallet+auth) and
  F-014/F-015/F-019/F-020/F-022/F-025/F-051/F-063 (top-High ship-safety),
  mirroring the contracts/backend pointer pattern.
- CHANGELOG now in reverse-chronological order with Frontend PR Pi-Defi-world#25 at
  top; Master Index Refresh entry cites PR Pi-Defi-world#25 directly; legacy\n  \u2018_(Future) Frontend_\u2019 placeholder retired.
- F-004 (item 20) remains Critical in Top 20 without a per-item pointer\n  by design \u2014 not in user\u2019s explicit 11-set; CHANGELOG documents this so\n  it is addressable in a follow-up PR.
…E.MD

- New nested 'Catalog consolidations' block under Project Management
  subsection listing PROJECT/issues/CONTRACTS_ISSUES.md (PR Pi-Defi-world#22),
  PROJECT/issues/BACKEND_ISSUES.md (PR Pi-Defi-world#23), and
  PROJECT/issues/FRONTEND_ISSUES.md (PR Pi-Defi-world#25) as durable long-form
  references with canonical-entry counts and severity distributions.
- Corrected the adjacent pre-existing 'Known issues' line link paths
  from bare filenames to the working 'issues/...' form so the whole
  block is discoverable.
- Bumped footer 'Last Updated:' from 2026-01-26 to 2026-06-20 to match
  the June catalog-consolidation PR envelope.
- Add F-066 \u2014 "Inconsistent loading / empty state skeletons across
  pages" (Medium, frontend/components) to issues/frontend.md and the
  Summary Table / Severity Counts / Resolution Tracker / Severity 5
  block of PROJECT/issues/FRONTEND_ISSUES.md.
- Migrate legacy Section 7 item #49 ("Empty and loading states
  inconsistent \u2014 missing Skeleton primitive") from "new \u2014 propose F-066"
  to "new \u2192 adopted as F-066", preserving the legacy #49 anchor for
  traceability.
- Severity distribution bumped from 5/14/23/23=65 \u2192 5/14/24/23=66.
  Summary Table totals line, Severity Counts row, and Resolution
  Tracker Medium cluster row all reconciled to (24 Medium).
- Cross-references: F-066 evidence path covers per-page loading.tsx /
  empty.tsx under app/(app)/**.
- Add F-071 \u2014 "Toast removal delay is ~17 minutes" (Medium,
  frontend/ux) to issues/frontend.md and the Summary Table / Severity
  Counts / Resolution Tracker / Severity 5 block of
  PROJECT/issues/FRONTEND_ISSUES.md.
- Migrate legacy Section 7 item #71 ("Toast removal delay is ~17
  minutes; TOAST_REMOVE_DELAY = 1000000") from "new \u2014 propose F-071"
  to "new \u2192 adopted as F-071", preserving the legacy #71 anchor for
  traceability.
- Severity distribution bumped from 5/14/24/23=66 \u2192
  5/14/25/23=67. Summary Table totals line, Severity Counts row, and
  Resolution Tracker Medium cluster row all reconciled to (25 Medium).
- Cross-references: F-071 evidence points at
  acbu-frontend/lib/toast.ts TOAST_REMOVE_DELAY constant.
- Build context: this PR builds on fix/frontend-canonical-id-f066 (PR
  Pi-Defi-world#28, the F-066 migration) which is now part of the branch base.
…eout)

- Add F-076 \u2014 "Frontend request() helper has no default timeout" (High,
  frontend/api) to issues/frontend.md and the Summary Table / Severity
  Counts / Resolution Tracker / Severity 4 block of
  PROJECT/issues/FRONTEND_ISSUES.md.
- Migrate legacy Section 7 item #76 ("API fetch has no timeout;
  Frontend request() uses fetch with no default timeout") from "new
  \u2014 propose F-076" to "new \u2192 adopted as F-076", preserving the
  legacy #76 anchor for traceability.
- Severity distribution bumped from 5/14/25/23=67 \u2192
  5/15/25/23=68. Summary Table totals line, Severity Counts High row,
  and Resolution Tracker High cluster row all reconciled to (15 High).
- Cross-references: F-076 evidence points at
  acbu-frontend/lib/api/client.ts request() function.
- Build context: this PR builds on fix/frontend-canonical-id-f071 (PR
  Pi-Defi-world#29, the F-071 migration) which is on top of fix/frontend-canonical-id-f066
  (PR Pi-Defi-world#28). Both prior PRs are part of the branch base.
- Add F-067..F-077 to issues/frontend.md in the canonical
  severity/area/evidence/impact/fix/acceptance format.
- Mirror into PROJECT/issues/FRONTEND_ISSUES.md Summary Table,
  Severity Counts (Medium 25\u219228, Low 23\u219229), Resolution Tracker
  Medium/Low cluster rows, Section 5 Medium (3 detailed entries),
  Section 6 Low (6 detailed entries), and totals 68\u219277.
- Migrate legacy Section 7 markers #55, #56, #68, #69, #72, #73,
  #74, #75, #77 from "new \u2014 propose F-XXX" to "new \u2192 adopted as F-XXX".
- Final distribution: 5 Critical / 15 High / 28 Medium / 29 Low = 77.
- Severity rationale: F-067/F-068/F-074 \u2192 Medium (data validation,
  silent-normalization privacy concern); F-069/F-070/F-072/F-073/F-075/
  F-077 \u2192 Low (perf / nav-pattern / hygiene, fail-open where
  appropriate).
- Branch builds on fix/frontend-canonical-id-f066, f071, f076
  (PRs Pi-Defi-world#28, Pi-Defi-world#29, Pi-Defi-world#30) \u2014 sequential stack so each layer merges cleanly.
…F-071/F-076 follow-ups

- Refresh the FRONTEND_ISSUES.md line under 'Catalog consolidations'
  to reflect the new distribution 5 Critical / 15 High / 25 Medium /
  23 Low = 68 canonical entries (F-001..F-076), up from the post-PR Pi-Defi-world#25
  distribution of 65 entries.
- Add explicit follow-up PR links (Pi-Defi-world#28 F-066 Skeleton primitive,
  Pi-Defi-world#29 F-071 Toast-deletion delay, Pi-Defi-world#30 F-076 Frontend request() no
  default timeout) so contributors can navigate from the README to
  the canonical-ID-migration PRs without grepping CHANGELOGs.
- Per the user's explicit scope: this PR captures PRs Pi-Defi-world#28..Pi-Defi-world#30 only;
  PR Pi-Defi-world#31 (F-067..F-077 batch) is a separate follow-up if the
  consolidated totals should advance further.
…rld#30 + Top 20 reorder for F-076

- Append a single '2026-06 \u2014 F-066/F-071/F-076 follow-up canonical-ID
  migrations (PRs Pi-Defi-world#28\u201330)' CHANGELOG entry at the top of the index, in
  the same strict reverse-chronological position used by prior entries.
  The new entry cites [PR Pi-Defi-world#28](F-066), [PR Pi-Defi-world#29](F-071), and
  [PR Pi-Defi-world#30](F-076) with their respective legacy-to-canonical migrations,
  severity transitions (frontend 5/14/23/23=65 \u2192 5/15/25/23=68), and
  explicit pointer to the Top-20 ship-safety reorder for F-076.
- Refresh the master index intro line: `Frontend (acbu-frontend)` 65
  \u2192 68 items; `Total` 200 \u2192 203.
- Refresh Catalog sources & deduping FRONTEND_ISSUES.md bullet to
  cite PRs Pi-Defi-world#28/Pi-Defi-world#29/Pi-Defi-world#30 alongside the original PR Pi-Defi-world#25, distribution
  5 / 15 / 25 / 23, and canonical-ID range F-001..F-076.
- Top 20 ship-safety list reordered: F-076 inserted into the High
  frontend cluster between F-063 and F-020 (the new network-safety
  item with full per-item tracker pointer); F-004 dropped from the
  closing slot (previously lacked a per-item pointer). All 20 entries
  now have an `…#resolution-tracker-fix-status` pointer.
- Note: this PR covers PRs Pi-Defi-world#28..Pi-Defi-world#30 only. The 9 remaining `(new)`
  Section 7 items proposed for F-067..F-077 promotion (#55, #56,
  #68, #69, #72, #73, #74, #75, #77) are batched separately in
  PR Pi-Defi-world#31; a subsequent master index CHANGELOG entry can be added when
  PR Pi-Defi-world#31 merges.
…Pi-Defi-world#33 CHANGELOG entry

PR Pi-Defi-world#33's CHANGELOG entry appended a sub-bullet at the end stating the
9 outstanding Section 7 (new) items, with a trailing "(see PR Pi-Defi-world#31)"
forward-pointer to the batched follow-up that would migrate them. PR
Pi-Defi-world#31 has now closed that backlog, so the forward-pointer is no longer
forward — it reads to a future reader as a vague reference rather
than as historical context.

Trim the trailing "(see PR Pi-Defi-world#31)." tail from that sub-bullet only.
The sub-bullet's content is otherwise preserved verbatim: the
"Outstanding (new) items" framing, the legacy ID list (#55, #56,
#68, #69, #72, #73, #74, #75, #77), and the proposed F-067..F-077
canonical mapping all remain as historical audit trail.

Single file: issues/MASTER_INDEX.md. Single change: removal of one
trailing substring " (see PR Pi-Defi-world#31)." from line 67. No arithmetic /
count changes. No other files touched.

Branched off docs/master-index-changelog-pr28-30 (= PR Pi-Defi-world#33 branch)
so the trim lands cleanly on top of the line it amends.
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Three PROJECT/issues/ catalog files (BACKEND_ISSUES.md, CONTRACTS_ISSUES.md, FRONTEND_ISSUES.md) are rewritten from simple severity-grouped lists into structured canonical triage catalogs covering 75, 60, and 77 items respectively. Twelve new frontend issues (F-066–F-077) are added to issues/frontend.md. The master index is updated with revised counts and resolution-tracker links, and PROJECT/README.MD is updated accordingly.

Changes

Issue Catalog Consolidation

Layer / File(s) Summary
New frontend backlog issues F-066–F-077
issues/frontend.md
Adds 12 new entries covering loading/empty state inconsistency, excessive toast delay, missing request() timeout, input validation gaps, icon re-creation on render, router.push vs <Link>, mobile detection misclassification, KYC setTimeout leak, silent username normalization, auto-fill minimum length, and /p2p client-side redirect.
Backend catalog restructure (B-001–B-075)
PROJECT/issues/BACKEND_ISSUES.md
Rewrites the file into a 75-item canonical catalog: adds provenance header, summary table, severity counts, per-item triage entries (evidence/impact/fix direction/acceptance check) across Critical/High/Medium/Low sections, a legacy 56-item cross-reference with (moved)/(new) tags, resolution tracker, cross-reference map, top remediations runbook, and maintenance instructions.
Contracts catalog restructure (C-001–C-060)
PROJECT/issues/CONTRACTS_ISSUES.md
Rewrites the file into a 60-item canonical catalog with usage instructions, full summary table, per-item triage entries across all severity sections, a legacy 34-item cross-reference, resolution tracker table, cross-reference map, top remediations checklist, maintenance instructions, and related documents list.
Frontend catalog restructure (F-001–F-077)
PROJECT/issues/FRONTEND_ISSUES.md
Rewrites the file into a 77-item canonical catalog incorporating the new F-066–F-077 entries; adds usage instructions, summary table, per-item triage entries, a legacy 77-item cross-reference preserving prior ordering with (moved)/(new) tags, resolution tracker, cross-reference map, top remediations runbook, and maintenance instructions dated June 2026.
Master index and README update
issues/MASTER_INDEX.md, PROJECT/README.MD
Updates frontend item count to 68 (total 203), replaces the deduping section with a catalog-sources description, rewrites the Top 20 list with #resolution-tracker-fix-status anchor links, adds a reverse-chronological CHANGELOG section, and updates PROJECT/README.MD Known Issues with nested catalog-consolidation bullets and a June 20, 2026 date.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Hop, hop — the catalog's neat,
Each B, C, and F gets a triage seat!
Severity counted, legacy mapped,
Ship-blockers flagged, no issue unwrapped.
The master index now links to the tracker,
No bunny leaves bugs in the dark any blacker! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the specific change: removing a forward-pointer parenthetical from a CHANGELOG entry in the master index file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (2)
PROJECT/issues/BACKEND_ISSUES.md (1)

1-108: ⚖️ Poor tradeoff

Summary Table ordering inconsistency with stated rule.

Like the frontend catalog, the backend Summary Table (lines 18–95) lists items in strict ID order (B-001..B-075) rather than grouping by severity first, then ID — contradicting the stated rule on lines 7–8: "Items are ordered by severity (Critical → Low), then by ID."

For consistency with the stated rule, the table should be re-sorted: Critical (B-005–B-006), then High, then Medium, then Low — with IDs ascending within each band. Alternatively, clarify that the Summary Table uses ID order while the detailed sections use severity order.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@PROJECT/issues/BACKEND_ISSUES.md` around lines 1 - 108, The Summary Table
lists items in strict ID order (B-001 through B-075) but the documented rule
states items should be ordered by severity first (Critical, then High, then
Medium, then Low) and then by ID within each severity band. Re-sort the Summary
Table so that Critical items appear first (B-005, B-006), followed by High items
(B-001 through B-004, B-007 through B-011, etc.), then Medium items, then Low
items, with IDs ascending within each severity group to align the Summary Table
with the stated ordering rule documented in the "How to use" section.
PROJECT/issues/FRONTEND_ISSUES.md (1)

14-98: ⚖️ Poor tradeoff

Summary Table violates stated ordering rule.

Line 8 says items are "ordered by severity (Critical → Low), then by ID for stable cross-referencing," but the Summary Table (lines 18–97) interleaves new issues (F-066, F-071, F-076, F-067–F-077) within the severity bands rather than grouping them at the end by ID sequence.

For example, within the Medium band, you have F-007, F-009, ..., F-064, then F-066, F-067, F-068, then F-071, then F-074. This breaks the "then by ID" rule.

Recommend re-sorting the Summary Table so that within each severity, IDs ascend monotonically: Critical (F-001–F-005), High (F-006, F-010, ..., F-076), Medium (F-007, F-009, ..., F-074), Low (F-008, F-011, ..., F-077).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@PROJECT/issues/FRONTEND_ISSUES.md` around lines 14 - 98, The Summary Table
violates the stated ordering rule by interleaving issue IDs within severity
bands rather than maintaining monotonic ascending ID order within each severity
group. Re-sort all rows in the Summary Table to group by severity (Critical,
High, Medium, Low) and then arrange IDs in ascending numerical order within each
severity band. For example, ensure all Critical issues (F-001 through F-005)
appear consecutively, then all High issues in ID order (F-006, F-010, F-014,
F-015, F-018, F-019, F-020, F-021, F-022, F-023, F-025, F-027, F-051, F-063,
F-076), then all Medium issues in ID order, then all Low issues in ID order.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@issues/MASTER_INDEX.md`:
- Line 6: The MASTER_INDEX.md file contains multiple outdated references to the
frontend item count. Update the file to reflect the correct count of 77 frontend
items with range F-001..F-077 instead of 68 items with range F-001..F-076.
Specifically, find and update all instances: the "68 items" reference at the
frontend line count, update the total item count from 203 to 211, correct the
range notation from F-001..F-076 to F-001..F-077 wherever it appears in the
frontend section headers and inventory, and update the severity breakdown from
"5 / 15 / 25 / 23 = 68" to "5 / 15 / 28 / 29 = 77" to match the canonical
catalog in FRONTEND_ISSUES.md.

In `@PROJECT/issues/FRONTEND_ISSUES.md`:
- Around line 102-110: The total count in the Severity Counts table is
incorrect. The sum of all severity categories (Critical: 5 + High: 15 + Medium:
28 + Low: 29) equals 77, but the Total row shows 65. Update the Total field in
the Severity Counts table to reflect the correct sum of 77.

In `@PROJECT/README.MD`:
- Around line 53-57: The Frontend entry count in the Catalog consolidations
section of the README.md contains a mismatch between the total canonical entries
count and the severity distribution. Update the Frontend issues line (starting
with [`issues/FRONTEND_ISSUES.md`]) to correct the count from 68 canonical
entries (F-001..F-076) to 77 canonical entries (F-001..F-077) and update the
severity distribution from 5 🔴 Critical / 15 🟠 High / 25 🟡 Medium / 23 🟢 Low
to 5 🔴 Critical / 15 🟠 High / 28 🟡 Medium / 29 🟢 Low to ensure the counts
match across all severity levels.

---

Nitpick comments:
In `@PROJECT/issues/BACKEND_ISSUES.md`:
- Around line 1-108: The Summary Table lists items in strict ID order (B-001
through B-075) but the documented rule states items should be ordered by
severity first (Critical, then High, then Medium, then Low) and then by ID
within each severity band. Re-sort the Summary Table so that Critical items
appear first (B-005, B-006), followed by High items (B-001 through B-004, B-007
through B-011, etc.), then Medium items, then Low items, with IDs ascending
within each severity group to align the Summary Table with the stated ordering
rule documented in the "How to use" section.

In `@PROJECT/issues/FRONTEND_ISSUES.md`:
- Around line 14-98: The Summary Table violates the stated ordering rule by
interleaving issue IDs within severity bands rather than maintaining monotonic
ascending ID order within each severity group. Re-sort all rows in the Summary
Table to group by severity (Critical, High, Medium, Low) and then arrange IDs in
ascending numerical order within each severity band. For example, ensure all
Critical issues (F-001 through F-005) appear consecutively, then all High issues
in ID order (F-006, F-010, F-014, F-015, F-018, F-019, F-020, F-021, F-022,
F-023, F-025, F-027, F-051, F-063, F-076), then all Medium issues in ID order,
then all Low issues in ID order.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3d9f1ddb-e32c-4b8a-8ebb-8c8b74fe3ab1

📥 Commits

Reviewing files that changed from the base of the PR and between a9a1a45 and 3296cf7.

📒 Files selected for processing (6)
  • PROJECT/README.MD
  • PROJECT/issues/BACKEND_ISSUES.md
  • PROJECT/issues/CONTRACTS_ISSUES.md
  • PROJECT/issues/FRONTEND_ISSUES.md
  • issues/MASTER_INDEX.md
  • issues/frontend.md

Comment thread issues/MASTER_INDEX.md

- Backend (`acbu-backend`): **75** items — [backend.md](./backend.md)
- Frontend (`acbu-frontend`): **65** items — [frontend.md](./frontend.md)
- Frontend (`acbu-frontend`): **68** items — [frontend.md](./frontend.md)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify frontend catalog actual item counts by inspecting both files

echo "=== Checking /issues/frontend.md ==="
if [ -f "issues/frontend.md" ]; then
  # Count lines matching canonical ID patterns (F-XXX)
  rg -E '^\*\*F-[0-9]{3}\*\*' issues/frontend.md | wc -l
else
  echo "File not found: issues/frontend.md"
fi

echo ""
echo "=== Checking PROJECT/issues/FRONTEND_ISSUES.md ==="
if [ -f "PROJECT/issues/FRONTEND_ISSUES.md" ]; then
  # Count lines matching canonical ID patterns and extract range claims
  rg -E '^\| F-[0-9]{3}' PROJECT/issues/FRONTEND_ISSUES.md | wc -l
  echo ""
  echo "Range claims in FRONTEND_ISSUES.md:"
  rg -n 'F-001.*F-0[0-9]{2}' PROJECT/issues/FRONTEND_ISSUES.md -m 1
  rg -n 'total.*catalog' PROJECT/issues/FRONTEND_ISSUES.md -i
else
  echo "File not found: PROJECT/issues/FRONTEND_ISSUES.md"
fi

Repository: Pi-Defi-world/ACBU-DOCUMENTATION

Length of output: 657


🏁 Script executed:

# Check MASTER_INDEX.md content at the referenced lines
echo "=== Lines 1-30 of MASTER_INDEX.md ==="
head -30 issues/MASTER_INDEX.md | cat -n

echo ""
echo "=== Lines 60-73 of MASTER_INDEX.md (CHANGELOG section) ==="
sed -n '60,73p' issues/MASTER_INDEX.md | cat -n

Repository: Pi-Defi-world/ACBU-DOCUMENTATION

Length of output: 8864


Frontend item count in MASTER_INDEX.md is out of sync with the canonical catalog.

MASTER_INDEX.md claims 68 frontend items (range F-001..F-076), but PROJECT/issues/FRONTEND_ISSUES.md explicitly documents 77 total items (F-001..F-077) with severity breakdown 5 Critical / 15 High / 28 Medium / 29 Low (totaling 77, not 68). This requires updates at:

  • Line 6: "68 items" → 77
  • Line 9: "Total: 203" → 211 (75 + 60 + 77)
  • Line 21: "68 items (F-001..F-076)" → 77 items (F-001..F-077)
  • Line 26: "68 canonical entries (F-001..F-076)" → 77 items (F-001..F-077)
  • Line 65: "5 / 15 / 25 / 23 = 68" → 5 / 15 / 28 / 29 = 77

The range F-001..F-076 is mathematically inconsistent with 68 items (that range contains only 76 items); the correct range for 77 items is F-001..F-077. Per the CHANGELOG, nine outstanding items in Section 7 have been promoted to canonical status but the master index header and catalog inventory remain at the prior state.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@issues/MASTER_INDEX.md` at line 6, The MASTER_INDEX.md file contains multiple
outdated references to the frontend item count. Update the file to reflect the
correct count of 77 frontend items with range F-001..F-077 instead of 68 items
with range F-001..F-076. Specifically, find and update all instances: the "68
items" reference at the frontend line count, update the total item count from
203 to 211, correct the range notation from F-001..F-076 to F-001..F-077
wherever it appears in the frontend section headers and inventory, and update
the severity breakdown from "5 / 15 / 25 / 23 = 68" to "5 / 15 / 28 / 29 = 77"
to match the canonical catalog in FRONTEND_ISSUES.md.

Comment on lines +102 to +110
## 2. Severity Counts

| Severity | Count |
|----------|-------|
| 🔴 Critical | **5** (F-001–F-005) |
| 🟠 High | **15** (F-006, F-010, F-014, F-015, F-018–F-023, F-025, F-027, F-051, F-063, F-076) |
| 🟡 Medium | **28** (F-007, F-009, F-012, F-013, F-016, F-017, F-024, F-026, F-028–F-030, F-032, F-036–F-040, F-046, F-047, F-050, F-055, F-062, F-064, F-066, F-067, F-068, F-071, F-074) |
| 🟢 Low | **29** (F-008, F-011, F-031, F-033–F-035, F-041–F-045, F-048, F-049, F-052–F-054, F-056–F-061, F-065, F-069, F-070, F-072, F-073, F-075, F-077) |
| **Total** | **65** |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Math error in Severity Counts table.

Line 110 lists the total as **65**, but the header (line 98) and the breakdown (5 + 15 + 28 + 29) both sum to 77. This is likely a copy-paste error from an older version with fewer items.

🔢 Proposed fix
 | **Total** | **65** |
+| **Total** | **77** |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@PROJECT/issues/FRONTEND_ISSUES.md` around lines 102 - 110, The total count in
the Severity Counts table is incorrect. The sum of all severity categories
(Critical: 5 + High: 15 + Medium: 28 + Low: 29) equals 77, but the Total row
shows 65. Update the Total field in the Severity Counts table to reflect the
correct sum of 77.

Comment thread PROJECT/README.MD
Comment on lines +53 to +57
- **Known issues:** [Contracts](issues/CONTRACTS_ISSUES.md), [Backend](issues/BACKEND_ISSUES.md), [Frontend](issues/FRONTEND_ISSUES.md)
- **Catalog consolidations** (durable long-form references — single source of truth per domain, discoverable when triaging):
- [`issues/CONTRACTS_ISSUES.md`](issues/CONTRACTS_ISSUES.md) — 60 canonical entries (C-001..C-060); 6 🔴 Critical / 21 🟠 High / 24 🟡 Medium / 9 🟢 Low. Consolidated in [PR #22](https://github.com/Pi-Defi-world/ACBU-DOCUMENTATION/pull/22).
- [`issues/BACKEND_ISSUES.md`](issues/BACKEND_ISSUES.md) — 75 canonical entries (B-001..B-075); 2 🔴 Critical / 21 🟠 High / 38 🟡 Medium / 14 🟢 Low. Consolidated in [PR #23](https://github.com/Pi-Defi-world/ACBU-DOCUMENTATION/pull/23).
- [`issues/FRONTEND_ISSUES.md`](issues/FRONTEND_ISSUES.md) — 68 canonical entries (F-001..F-076); 5 🔴 Critical / 15 🟠 High / 25 🟡 Medium / 23 🟢 Low. Consolidated into the canonical format in [PR #25](https://github.com/Pi-Defi-world/ACBU-DOCUMENTATION/pull/25); expanded to 68 canonical entries via follow-up canonical-ID migrations in [PR #28](https://github.com/Pi-Defi-world/ACBU-DOCUMENTATION/pull/28) (F-066 Skeleton primitive, Medium), [PR #29](https://github.com/Pi-Defi-world/ACBU-DOCUMENTATION/pull/29) (F-071 Toast-deletion delay, Medium), and [PR #30](https://github.com/Pi-Defi-world/ACBU-DOCUMENTATION/pull/30) (F-076 Frontend `request()` no default timeout, High).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Frontend entry in "Catalog consolidations" carries the same count mismatch as MASTER_INDEX.

Line 57 lists: 68 canonical entries (F-001..F-076); 5 🔴 Critical / 15 🟠 High / 25 🟡 Medium / 23 🟢 Low

This mirrors the discrepancy noted in MASTER_INDEX.md. Once the source count is resolved (should be 77 items, F-001..F-077, with severities 5/15/28/29), this line must be updated to match.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@PROJECT/README.MD` around lines 53 - 57, The Frontend entry count in the
Catalog consolidations section of the README.md contains a mismatch between the
total canonical entries count and the severity distribution. Update the Frontend
issues line (starting with [`issues/FRONTEND_ISSUES.md`]) to correct the count
from 68 canonical entries (F-001..F-076) to 77 canonical entries (F-001..F-077)
and update the severity distribution from 5 🔴 Critical / 15 🟠 High / 25 🟡
Medium / 23 🟢 Low to 5 🔴 Critical / 15 🟠 High / 28 🟡 Medium / 29 🟢 Low to
ensure the counts match across all severity levels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant