Skip to content

docs(frontend): promote canonical ID F-066 (Shared Skeleton primitive)#28

Open
Adiz4415 wants to merge 7 commits into
Pi-Defi-world:mainfrom
Adiz4415:fix/frontend-canonical-id-f066
Open

docs(frontend): promote canonical ID F-066 (Shared Skeleton primitive)#28
Adiz4415 wants to merge 7 commits into
Pi-Defi-world:mainfrom
Adiz4415:fix/frontend-canonical-id-f066

Conversation

@Adiz4415

Copy link
Copy Markdown
Contributor

Summary

First of three follow-up canonical-ID PRs that promote (new) legacy findings (Section 7 of PROJECT/issues/FRONTEND_ISSUES.md, range F-066..F-077) into the canonical issues/frontend.md triage-ready catalog. This PR migrates legacy #49 (\u201cEmpty and loading states inconsistent \u2014 missing Skeleton primitive\u201d) into canonical F-066 (\u201cInconsistent loading / empty state skeletons across pages\u201d), Medium severity, frontend/components area.

What changed

issues/frontend.md

  • Appended canonical F-066 entry after F-065 in the same severity/area/evidence/impact/fix/acceptance format used elsewhere (Severity: Medium; Area: frontend/components).

PROJECT/issues/FRONTEND_ISSUES.md

  • Section 1 Summary Table \u2014 new row for F-066 added before the totals line; totals updated from 65 \u2192 66 items.
  • Section 2 Severity Counts \u2014 Medium bucket bumped 23 \u2192 24, including F-066 in the explicit ID range.
  • Section 3\u20136 Severity blocks \u2014 appended F-066 detailed entry to Section 5 (Medium), evidence pointing at per-page loading.tsx / empty.tsx wrappers across app/(app)/**.
  • Section 8 Resolution Tracker \u2014 Medium cluster row updated to include F-066 and (24 items) count.
  • Section 7 Legacy \u2014 row #49 marker migrated from (new \u2014 propose F-066) \u2014 (new \u2192 adopted as F-066 in companion canonical-ID PR; see Section 5 and Section 8 for canonical rows), preserving the legacy #49 anchor for traceability.
  • Summary Table totals, Severity Counts, and Resolution Tracker Medium cluster rows all reconciled to the same Medium=24 count (verified arithmetically: 5 + 14 + 24 + 23 = 66).

Why this matters

Section 7 of the consolidated catalog preserves 12 (new) distinct findings that pre-date the canonical rewrite and were flagged for promotion once they were actionable. This is PR 1 of 3 in the opening set, targeting the highest-impact UX/codegen items first.

Verification

  • Sanity check + code-reviewer-minimax-m3 both pass after the follow-up Medium: 23 \u2192 24 totals-line fix.
  • F-066 entry text internally consistent across both files.
  • 5 / 14 / 24 / 23 arithmetic = 66 (was 65).
  • No duplicates of F-066, no broken markdown tables.
  • Canonical F-001..F-065 set preserved; no regressions in the existing catalog.
  • Only the Section 7 #49 row's (new \u2026) marker tag was retargeted; the legacy #49 ordinal is preserved for downstream traceability.

Follow-ups

The remaining (new) legacy items proposed for canonical promotion: F-067..F-070, F-072..F-075, F-077. This PR (F-066), the planned PR 2 (F-071 toast-deletion delay), and PR 3 (F-076 missing fetch timeout) cover the highest-impact items the original backlog author flagged as ship-safety triage. Remaining 9 items are lower priority and can land in a single batched follow-up PR if preferred.

Adiz4415 added 7 commits June 20, 2026 12:25
…catalog

- Restructure PROJECT/issues/CONTRACTS_ISSUES.md into a single source of
  truth using canonical severity/area/evidence/impact/fix/acceptance format.
- Cover all 60 catalog entries from issues/contracts.md (Critical 6, High
  21, Medium 24, Low 9) with stable C-### IDs.
- Preserve the legacy 34-item list as Section 7 cross-reference.
- Add Summary Table, Severity Counts, Resolution Tracker, Top Remediations
  (ship-safety order), Cross-Reference Map, and Maintenance notes.
- Provide anchor points for future PR references.

Closes Pi-Defi-world#12
- Catalog sources & deduping section renames the prior Deduping section
  and explicitly elevates PROJECT/issues/CONTRACTS_ISSUES.md (PR Pi-Defi-world#22) and
  PROJECT/issues/BACKEND_ISSUES.md (PR Pi-Defi-world#23) to durable long-form references;
  FRONTEND_ISSUES.md remains legacy pending follow-up PR.
- Top 20 list gains per-item deep links to the Resolution Tracker
  (Section 8) of each consolidated catalog and uniformly bolds IDs.
- New CHANGELOG section appended in strict reverse-chronological order
  (this PR refresh first, then PR Pi-Defi-world#23 backend, then PR Pi-Defi-world#22 contracts,
  then future frontend consolidation).
…d 11 per-item tracker pointers

- Catalog sources & deduping elevates PROJECT/issues/FRONTEND_ISSUES.md
  to durable long-form reference (was legacy/\u2018pending follow-up\u2019), cited
  to PR Pi-Defi-world#25.
- Top 20 list gains per-item tracker pointers for the 11 user-listed
  frontend items: F-001/F-002/F-005 (Critical, wallet+auth) and
  F-014/F-015/F-019/F-020/F-022/F-025/F-051/F-063 (top-High ship-safety),
  mirroring the contracts/backend pointer pattern.
- CHANGELOG now in reverse-chronological order with Frontend PR Pi-Defi-world#25 at
  top; Master Index Refresh entry cites PR Pi-Defi-world#25 directly; legacy\n  \u2018_(Future) Frontend_\u2019 placeholder retired.
- F-004 (item 20) remains Critical in Top 20 without a per-item pointer\n  by design \u2014 not in user\u2019s explicit 11-set; CHANGELOG documents this so\n  it is addressable in a follow-up PR.
…E.MD

- New nested 'Catalog consolidations' block under Project Management
  subsection listing PROJECT/issues/CONTRACTS_ISSUES.md (PR Pi-Defi-world#22),
  PROJECT/issues/BACKEND_ISSUES.md (PR Pi-Defi-world#23), and
  PROJECT/issues/FRONTEND_ISSUES.md (PR Pi-Defi-world#25) as durable long-form
  references with canonical-entry counts and severity distributions.
- Corrected the adjacent pre-existing 'Known issues' line link paths
  from bare filenames to the working 'issues/...' form so the whole
  block is discoverable.
- Bumped footer 'Last Updated:' from 2026-01-26 to 2026-06-20 to match
  the June catalog-consolidation PR envelope.
- Add F-066 \u2014 "Inconsistent loading / empty state skeletons across
  pages" (Medium, frontend/components) to issues/frontend.md and the
  Summary Table / Severity Counts / Resolution Tracker / Severity 5
  block of PROJECT/issues/FRONTEND_ISSUES.md.
- Migrate legacy Section 7 item #49 ("Empty and loading states
  inconsistent \u2014 missing Skeleton primitive") from "new \u2014 propose F-066"
  to "new \u2192 adopted as F-066", preserving the legacy #49 anchor for
  traceability.
- Severity distribution bumped from 5/14/23/23=65 \u2192 5/14/24/23=66.
  Summary Table totals line, Severity Counts row, and Resolution
  Tracker Medium cluster row all reconciled to (24 Medium).
- Cross-references: F-066 evidence path covers per-page loading.tsx /
  empty.tsx under app/(app)/**.
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Adiz4415, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 6 minutes and 36 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bfacd11f-5d93-42da-86f8-bf0098dc0cd0

📥 Commits

Reviewing files that changed from the base of the PR and between ea8aa4b and d49b4b7.

📒 Files selected for processing (6)
  • PROJECT/README.MD
  • PROJECT/issues/BACKEND_ISSUES.md
  • PROJECT/issues/CONTRACTS_ISSUES.md
  • PROJECT/issues/FRONTEND_ISSUES.md
  • issues/MASTER_INDEX.md
  • issues/frontend.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant