docs(frontend): promote canonical ID F-071 (Toast removal delay ~17min)#29
Open
Adiz4415 wants to merge 8 commits into
Open
docs(frontend): promote canonical ID F-071 (Toast removal delay ~17min)#29Adiz4415 wants to merge 8 commits into
Adiz4415 wants to merge 8 commits into
Conversation
…catalog - Restructure PROJECT/issues/CONTRACTS_ISSUES.md into a single source of truth using canonical severity/area/evidence/impact/fix/acceptance format. - Cover all 60 catalog entries from issues/contracts.md (Critical 6, High 21, Medium 24, Low 9) with stable C-### IDs. - Preserve the legacy 34-item list as Section 7 cross-reference. - Add Summary Table, Severity Counts, Resolution Tracker, Top Remediations (ship-safety order), Cross-Reference Map, and Maintenance notes. - Provide anchor points for future PR references. Closes Pi-Defi-world#12
- Catalog sources & deduping section renames the prior Deduping section and explicitly elevates PROJECT/issues/CONTRACTS_ISSUES.md (PR Pi-Defi-world#22) and PROJECT/issues/BACKEND_ISSUES.md (PR Pi-Defi-world#23) to durable long-form references; FRONTEND_ISSUES.md remains legacy pending follow-up PR. - Top 20 list gains per-item deep links to the Resolution Tracker (Section 8) of each consolidated catalog and uniformly bolds IDs. - New CHANGELOG section appended in strict reverse-chronological order (this PR refresh first, then PR Pi-Defi-world#23 backend, then PR Pi-Defi-world#22 contracts, then future frontend consolidation).
…d 11 per-item tracker pointers - Catalog sources & deduping elevates PROJECT/issues/FRONTEND_ISSUES.md to durable long-form reference (was legacy/\u2018pending follow-up\u2019), cited to PR Pi-Defi-world#25. - Top 20 list gains per-item tracker pointers for the 11 user-listed frontend items: F-001/F-002/F-005 (Critical, wallet+auth) and F-014/F-015/F-019/F-020/F-022/F-025/F-051/F-063 (top-High ship-safety), mirroring the contracts/backend pointer pattern. - CHANGELOG now in reverse-chronological order with Frontend PR Pi-Defi-world#25 at top; Master Index Refresh entry cites PR Pi-Defi-world#25 directly; legacy\n \u2018_(Future) Frontend_\u2019 placeholder retired. - F-004 (item 20) remains Critical in Top 20 without a per-item pointer\n by design \u2014 not in user\u2019s explicit 11-set; CHANGELOG documents this so\n it is addressable in a follow-up PR.
…E.MD - New nested 'Catalog consolidations' block under Project Management subsection listing PROJECT/issues/CONTRACTS_ISSUES.md (PR Pi-Defi-world#22), PROJECT/issues/BACKEND_ISSUES.md (PR Pi-Defi-world#23), and PROJECT/issues/FRONTEND_ISSUES.md (PR Pi-Defi-world#25) as durable long-form references with canonical-entry counts and severity distributions. - Corrected the adjacent pre-existing 'Known issues' line link paths from bare filenames to the working 'issues/...' form so the whole block is discoverable. - Bumped footer 'Last Updated:' from 2026-01-26 to 2026-06-20 to match the June catalog-consolidation PR envelope.
- Add F-066 \u2014 "Inconsistent loading / empty state skeletons across
pages" (Medium, frontend/components) to issues/frontend.md and the
Summary Table / Severity Counts / Resolution Tracker / Severity 5
block of PROJECT/issues/FRONTEND_ISSUES.md.
- Migrate legacy Section 7 item #49 ("Empty and loading states
inconsistent \u2014 missing Skeleton primitive") from "new \u2014 propose F-066"
to "new \u2192 adopted as F-066", preserving the legacy #49 anchor for
traceability.
- Severity distribution bumped from 5/14/23/23=65 \u2192 5/14/24/23=66.
Summary Table totals line, Severity Counts row, and Resolution
Tracker Medium cluster row all reconciled to (24 Medium).
- Cross-references: F-066 evidence path covers per-page loading.tsx /
empty.tsx under app/(app)/**.
- Add F-071 \u2014 "Toast removal delay is ~17 minutes" (Medium,
frontend/ux) to issues/frontend.md and the Summary Table / Severity
Counts / Resolution Tracker / Severity 5 block of
PROJECT/issues/FRONTEND_ISSUES.md.
- Migrate legacy Section 7 item #71 ("Toast removal delay is ~17
minutes; TOAST_REMOVE_DELAY = 1000000") from "new \u2014 propose F-071"
to "new \u2192 adopted as F-071", preserving the legacy #71 anchor for
traceability.
- Severity distribution bumped from 5/14/24/23=66 \u2192
5/14/25/23=67. Summary Table totals line, Severity Counts row, and
Resolution Tracker Medium cluster row all reconciled to (25 Medium).
- Cross-references: F-071 evidence points at
acbu-frontend/lib/toast.ts TOAST_REMOVE_DELAY constant.
- Build context: this PR builds on fix/frontend-canonical-id-f066 (PR
Pi-Defi-world#28, the F-066 migration) which is now part of the branch base.
📝 WalkthroughWalkthroughThree domain issue catalogs ( ChangesIssue Catalog Consolidation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@PROJECT/issues/FRONTEND_ISSUES.md`:
- Around line 92-100: The total count in the Severity Counts table (Section 2,
final row) is incorrect. Update the total from 65 to 67 to match the sum of all
severity level counts (5 Critical + 14 High + 25 Medium + 23 Low = 67) and
ensure consistency with the 67 total catalog items referenced in the Summary
Table header on line 88.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a09ff442-5f27-4a33-bd21-f3749360c35c
📒 Files selected for processing (6)
PROJECT/README.MDPROJECT/issues/BACKEND_ISSUES.mdPROJECT/issues/CONTRACTS_ISSUES.mdPROJECT/issues/FRONTEND_ISSUES.mdissues/MASTER_INDEX.mdissues/frontend.md
Comment on lines
+92
to
+100
| ## 2. Severity Counts | ||
|
|
||
| | Severity | Count | | ||
| |----------|-------| | ||
| | 🔴 Critical | **5** (F-001–F-005) | | ||
| | 🟠 High | **14** (F-006, F-010, F-014, F-015, F-018–F-023, F-025, F-027, F-051, F-063) | | ||
| | 🟡 Medium | **25** (F-007, F-009, F-012, F-013, F-016, F-017, F-024, F-026, F-028–F-030, F-032, F-036–F-040, F-046, F-047, F-050, F-055, F-062, F-064, F-066, F-071) | | ||
| | 🟢 Low | **23** (F-008, F-011, F-031, F-033–F-035, F-041–F-045, F-048, F-049, F-052–F-054, F-056–F-061, F-065) | | ||
| | **Total** | **65** | |
There was a problem hiding this comment.
Severity Counts total is incorrect: should be 67, not 65.
Line 100 reports Total | 65, but the sum of counts (5 Critical + 14 High + 25 Medium + 23 Low) equals 67. This must match the total claimed in the Summary Table header (line 88: "67 total catalog items"). Update Section 2 total to 67.
✏️ Proposed fix
| **Total** | **65** |
+| **Total** | **67** |🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@PROJECT/issues/FRONTEND_ISSUES.md` around lines 92 - 100, The total count in
the Severity Counts table (Section 2, final row) is incorrect. Update the total
from 65 to 67 to match the sum of all severity level counts (5 Critical + 14
High + 25 Medium + 23 Low = 67) and ensure consistency with the 67 total catalog
items referenced in the Summary Table header on line 88.
This was referenced Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR 2 of three follow-up canonical-ID migrations promoting
(new)legacy findings (Section 7 ofPROJECT/issues/FRONTEND_ISSUES.md, proposed rangeF-066..F-077) into the canonical triage-ready catalogissues/frontend.md. This PR migrates legacy #71 (\u201cToast removal delay is ~17 minutes \u2014TOAST_REMOVE_DELAY = 1000000\u201d) into canonical F-071 (\u201cToast removal delay is ~17 minutes\u201d), Medium severity,frontend/uxarea.What changed
issues/frontend.mdacbu-frontend/lib/toast.tsconstant).PROJECT/issues/FRONTEND_ISSUES.md(new \u2014 propose F-071)\u2192(new \u2192 adopted as F-071 in companion canonical-ID PR; see Section 5 and Section 8 for canonical rows), preserving legacy #71 anchor for traceability.Build context
This PR is branched from PR #28 (\u201cF-066 canonical-ID migration\u201d). When PR #28 merges to main, this branch can be fast-forwarded / rebased. The branch base includes all F-066 changes (medium 23 \u2192 24); this PR adds medium 24 \u2192 25 (with F-071).
Why this matters
The 17-minute toast linger is more than cosmetic in a financial app: stale transaction-context toasts can persist long enough for shoulder-surfing and erode user trust. Fix direction: sane default dismiss + explicit
sticky: trueopt-in.Verification
Follow-up
PR 3 of this series will migrate legacy #76 (\u201cAPI fetch has no timeout\u201d) into canonical F-076 (High severity; financial-app network hang risk). After that, the remaining
(new)items in Section 7 (proposed F-067..F-070, F-072..F-075, F-077) can be addressed in a single batched follow-up PR if preferred.Summary by CodeRabbit
Documentation
New Features