Skip to content

docs(contracts): consolidate CONTRACTS_ISSUES.md to close #12#22

Open
Adiz4415 wants to merge 1 commit into
Pi-Defi-world:mainfrom
Adiz4415:fix/contracts-issues-catalog-issue-12
Open

docs(contracts): consolidate CONTRACTS_ISSUES.md to close #12#22
Adiz4415 wants to merge 1 commit into
Pi-Defi-world:mainfrom
Adiz4415:fix/contracts-issues-catalog-issue-12

Conversation

@Adiz4415

Copy link
Copy Markdown
Contributor

Summary

Closes #12 — consolidates the ACBU smart contracts known-issues catalog into a single, durable source of truth at PROJECT/issues/CONTRACTS_ISSUES.md.

What changed

  • Restructured PROJECT/issues/CONTRACTS_ISSUES.md from a 34-item flat list into the canonical severity/area/evidence/impact/fix/acceptance format used by issues/contracts.md.
  • Coverage expanded from 34 → 60 catalog entries, fully aligned with issues/contracts.md (C-001 through C-060). Severity distribution: 6 Critical, 21 High, 24 Medium, 9 Low.
  • Stable IDs preserved: every legacy item now resolves to a canonical C-### ID via the legacy cross-reference section.
  • Added structural sections: Summary Table, Severity Counts, Resolution Tracker (Section 8) for fix-status anchors, Top Remediations (ship-safety order), Cross-Reference Map, and Maintenance guidelines.
  • Acceptance criteria included for every entry so each issue can be unambiguously verified when fixed.

Why

Issue #12 ("Smart contracts known issues (exists in PROJECT/issues/)") was assigned via the GrantFox Official Campaign. Following the established project pattern (see PR #14 for #1, CONTRIBUTING_GUIDE.MD), resolving this issue means producing the durable, comprehensive knowledge artifact the issue calls for. This file is the durable long-form reference; issues/contracts.md remains the live triage-ready catalog and is now faithfully mirrored.

Verification

  • IDs C-001 through C-060 all present.
  • Severity counts tally: 6 + 21 + 24 + 9 = 60 (matches the canonical catalog).
  • Cross-reference paths resolve from PROJECT/issues/ to companion files: ../../issues/contracts.md, ../SMART_CONTRACT_SPEC.md, ../../TECHNICAL/..., ../../correction.md.
  • Legacy list preserved as Section 7 with explicit (moved) tags so reviewers can trace every original item.

Related

  • Closes CONTRACTS_ISSUES.md #12
  • Mirrors issues/contracts.md
  • Preserves legacy content from prior PROJECT/issues/CONTRACTS_ISSUES.md
  • Cross-referenced by DOCS/SMART_CONTRACT_SPEC.MD Known Issues section

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Adiz4415, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 57 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e617ee0c-fa95-42cf-a49c-5a185b39b411

📥 Commits

Reviewing files that changed from the base of the PR and between ea8aa4b and 23d9bb5.

📒 Files selected for processing (1)
  • PROJECT/issues/CONTRACTS_ISSUES.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…catalog

- Restructure PROJECT/issues/CONTRACTS_ISSUES.md into a single source of
  truth using canonical severity/area/evidence/impact/fix/acceptance format.
- Cover all 60 catalog entries from issues/contracts.md (Critical 6, High
  21, Medium 24, Low 9) with stable C-### IDs.
- Preserve the legacy 34-item list as Section 7 cross-reference.
- Add Summary Table, Severity Counts, Resolution Tracker, Top Remediations
  (ship-safety order), Cross-Reference Map, and Maintenance notes.
- Provide anchor points for future PR references.

Closes Pi-Defi-world#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CONTRACTS_ISSUES.md

1 participant