vutil.c: Use new SvVSTRING() macro - #23154
Closed
leonerd wants to merge 1 commit into
Closed
Conversation
Contributor
|
This file's upstream is version.pm, and should not be modified in core. |
Contributor
Effectively that means |
Contributor
Author
Sounds like something for @khwilliamson then |
Leont
added
the
Closable?
leonerd
force-pushed
the
use-SvVSTRING-in-vutil-c
branch
from
March 26, 2025 16:07
ebed084 to
e86607e
Compare
Contributor
|
I think this can be closed, and instead a PR should be opened against version.pm |
jkeenan
pushed a commit
to jkeenan/version.pm
that referenced
this pull request
Jun 9, 2025
Committer: Originally submitted by Paul Evans to Perl core distribution as Perl/perl5#23154. It was recommended that it be submitted upstream first.
Contributor
|
Discussion moved upstream to Perl/version.pm#45. Closing this ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
SvVSTRINGmacro means callers don't have to be aware of the current (magic-based) implementation of vstrings. When I added it in 80f24f4 I overlooked this file for changes. Here's two more places it should be used from.