Dumper.xs: use new SvVSTRING API - #23165
Merged
Merged
Conversation
Contributor
Author
|
Oops, I broke the old perls. Shall have to investigate that... |
Contributor
|
I'm assuming this needs #23160 |
Contributor
jkeenan
added
the
dist-Data-Dumper
Contributor
|
This p.r. has a dependency on another p.r. and must also pass on earlier versions of perl. Should we hold it until the 5.43 dev cycle? |
Contributor
|
Rebasing on blead should fix this. |
leonerd
force-pushed
the
use-SvVSTRING-in-Dumper
branch
2 times, most recently
from
April 7, 2025 14:24
e8d4eae to
7d98cbe
Compare
Contributor
Author
|
Reviewers: This seems to be working now |
tonycoz
approved these changes
Apr 9, 2025
Contributor
Sounds like a rebase went wrong? |
Contributor
Author
Oh oops, I pressed the "merge" button not realising it was going to merge blead into the branch. Let me fix that up. |
Use the new abstraction API rather than direct access to the MAGIC structures.
leonerd
force-pushed
the
use-SvVSTRING-in-Dumper
branch
from
April 10, 2025 09:37
e97b750 to
3cf5512
Compare
Leont
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new abstraction API rather than direct access to the MAGIC structures.