Repository navigation
fix(security): keep GitHub token out of validation job environments - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The controlled live-validation workflow set
GH_TOKENat job scope, exposing GitHub's ephemeral read-only credential to package install, build, tests, and other commands that did not need it. Existing workflow policy tests checked the number of token references but not their placement.Changes
GH_TOKENfrom both the no-key matrix and the live-model job.scripts/e2e-validation.mjsdriver step, which needsghto read a public GitHub issue. That driver already strips tokens from its public Git, package and model-controlled workspace child commands; the main workflow install, build, audits, deterministic suite and sandbox proof are now token-free.Scope and evidence
ae64aeac3061afd718369f0cc62b0cc73ad1d863, which already passed six-platform CI and eight scripted customer journeys.Release conditions
Do not merge until full hosted matrix and scripted customer tests pass. After merge, requalify exact main SHA before live-model dispatch. Preserve the manual-only input, model request ceiling of 12, sandbox boundary, and no-publication policy.