Skip to content

fix(validate-generated-configs): use is_file() guard and catch OSError when reading contract - #5883

Closed
vaibhavsrv wants to merge 1 commit into
Osmantic:public-betafrom
vaibhavsrv:fix/validate-generated-configs-file-guard
Closed

vaibhavsrv wants to merge 1 commit into
Osmantic:public-betafrom
vaibhavsrv:fix/validate-generated-configs-file-guard

Conversation

@vaibhavsrv

Copy link
Copy Markdown
Contributor

Why this matters

In ods/scripts/validate-generated-configs.py, main() checks path.exists() before reading the contract file. path.exists() returns True for directories as well as regular files. When validate-generated-configs.py is invoked with a directory path — for instance from a CI step that uses a shell glob or mis-configured path — path.read_text(encoding="utf-8") raises IsADirectoryError, a subclass of OSError, which is not caught by the subsequent except json.JSONDecodeError block. The unhandled exception surfaces as a raw Python traceback, masking the contract failure behind a confusing crash and potentially allowing CI pipelines to exit with an error code that doesn't map to a clear [FAIL] diagnostic.

This patch changes path.exists() to path.is_file() and broadens the except clause to (OSError, json.JSONDecodeError), ensuring all file system failures, permission errors, and directory paths are caught and reported as structured [FAIL] messages.

Validation

  • Repro baseline: Passed a directory path to validate-generated-configs.py; confirmed baseline raised unhandled IsADirectoryError traceback instead of a clean [FAIL] message.
  • Post-fix: Verified ods/tests/test_validate_generated_configs_file_guard.py passes with exit code 0; directory, missing, and invalid-JSON paths all produce [FAIL] output with non-zero exit codes.
  • Generated config contract suites: 3 passed. New-test syntax and diff checks pass; new regressions wired into Linux CI.

Overlap check

Risk / AI disclosure

AI-assisted investigation, implementation and CLI regressions. This strengthens input validation in the generated config contract validator; runtime daemon behavior, model catalogs, and installer flows are not altered. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.

Follow-up integration evidence

Composed with #5882 at 2eb02a531 without conflicts. Production and test diffs passed together; adjacent runtime config renderer and generated config contract tests remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.

@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants