Repository navigation
fix(validate-generated-configs): use is_file() guard and catch OSError when reading contract - #5883
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
…r when reading contract
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/validate-generated-configs.py,main()checkspath.exists()before reading the contract file.path.exists()returnsTruefor directories as well as regular files. Whenvalidate-generated-configs.pyis invoked with a directory path — for instance from a CI step that uses a shell glob or mis-configured path —path.read_text(encoding="utf-8")raisesIsADirectoryError, a subclass ofOSError, which is not caught by the subsequentexcept json.JSONDecodeErrorblock. The unhandled exception surfaces as a raw Python traceback, masking the contract failure behind a confusing crash and potentially allowing CI pipelines to exit with an error code that doesn't map to a clear[FAIL]diagnostic.This patch changes
path.exists()topath.is_file()and broadens the except clause to(OSError, json.JSONDecodeError), ensuring all file system failures, permission errors, and directory paths are caught and reported as structured[FAIL]messages.Validation
validate-generated-configs.py; confirmed baseline raised unhandledIsADirectoryErrortraceback instead of a clean[FAIL]message.ods/tests/test_validate_generated_configs_file_guard.pypasses with exit code 0; directory, missing, and invalid-JSON paths all produce[FAIL]output with non-zero exit codes.Overlap check
Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens input validation in the generated config contract validator; runtime daemon behavior, model catalogs, and installer flows are not altered. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #5882 at
2eb02a531without conflicts. Production and test diffs passed together; adjacent runtime config renderer and generated config contract tests remain intact.Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.