Repository navigation
fix(assign-gpus): specify UTF-8 encoding and catch OSError in topology file reader - #5884
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/assign_gpus.py, the topology file is opened viaopen(args.topology)without an explicit encoding parameter. On Python's default behavior,open()uses the locale-preferred encoding —cp1252on Windows,asciiin minimal containers. When the topology JSON file contains non-ASCII characters (e.g. GPU model names with trademark symbols or non-Latin characters),json.load()encounters aUnicodeDecodeErrorthat is not caught by the narrowexcept FileNotFoundErrorblock, producing an unhandled traceback rather than a clean error exit. Additionally,PermissionErrorandIsADirectoryError— both subclasses ofOSError— also escape the narrowFileNotFoundErrorhandler and crash with a raw Python traceback.This patch adds
encoding="utf-8"to theopen()call and widens the exception clause fromexcept FileNotFoundErrortoexcept OSError, ensuring all file access failures produce a clean error message and a non-zero exit code consistent with the script's existing error reporting style.Validation
RTX™ 4090) as UTF-8; confirmed thatopen(args.topology)without encoding raisedUnicodeDecodeErrorin locales where the default is not UTF-8. Confirmed thatexcept FileNotFoundErrordid not catch permission failures.ods/tests/test_assign_gpus_topology_encoding.pypasses with exit code 0; missing and invalid-JSON topology files produce cleanERRORmessages on stderr with non-zero exit codes.Overlap check
Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens portable JSON reading and OSError handling in GPU topology loading; GPU assignment logic, driver interaction, and capacity decisions are not altered. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #5883 at
9a254c687without conflicts. Production and test diffs passed together; adjacent GPU assignment capacity and spare capacity contracts remain intact.Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.