Repository navigation
fix(gpu): respect dotenv override precedence and export prefix in env reader - #5877
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/dashboard-api/gpu.py,_read_env_var_from_file_state()reads environment variables (such asGPU_ASSIGNMENT_JSON_B64andGPU_BACKEND) from the live.envfile by returning immediately upon the first matching prefix (return True, ...). This breaks standard dotenv and POSIX override semantics where assignments appended later in.envoverride baseline defaults defined earlier. Furthermore, lines formatted with shellexportprefixes were not recognized, and reading without explicit UTF-8 decoding combined withexcept OSError:failed to catchUnicodeDecodeErrorwhen.envcontained non-ASCII characters.This patch updates
_read_env_var_from_file_state()to scan the entire.envfile so that later overrides take precedence, adds support forexportprefixes, and enforces safe UTF-8 decoding with Unicode error handling.Validation
.envwith defaultGPU_BACKEND=cpufollowed by overrideGPU_BACKEND=nvidia; confirmed baseline returnedcpu. Providedexport GPU_ACCELERATOR=cuda; confirmed baseline returnedfound=False.ods/tests/test_gpu_env_precedence.pypasses with exit code 0;_read_env_var_from_file_statereturnsnvidiaandcudarespectively, and handles Unicode characters safely.Overlap check
Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens dotenv reading and override precedence in GPU configuration discovery, not driver or kernel execution. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #5871 at 81b881c without conflicts. Production and test diffs passed together; GPU detection and assignment contracts remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.