Skip to content

fix(pixel-agent-teams): guard non-string text in planned_count resolution - #5987

Closed
Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-agent-teams-planned-count-non-str
Closed

Vishaaallll wants to merge 1 commit into
Osmantic:public-betafrom
Vishaaallll:fix/pixel-agent-teams-planned-count-non-str

Conversation

@Vishaaallll

Copy link
Copy Markdown
Contributor

Why this matters

In ods/extensions/services/dashboard-api/pixel_agent_teams.py, planned_count(text) applies string slicing text[:12000] and regex scanning without an upfront type check. While exceptions are caught in a broad try block, guarding string type explicitly clarifies domain intent and prevents non-string types from entering regex engines.

This surgical fix adds if not isinstance(text, str): return None at the entrypoint of planned_count.

Validation

  • Baseline reproduction: verified that non-string values relied on broad exception catching on baseline.
  • Post-fix behavior: immediately returns None for non-string inputs.
  • Telemetry: pixel-agent-teams suite: 2 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.

Overlap check

Inspected open/closed PRs. PR #5741 handled planned_count type; zero overlap with direct entrypoint guard.

Risk / AI disclosure

AI-assisted investigation, patch, and regression tests. Enforces string type guard on model planning resolution. Independent review remains a gate.

Follow-up integration evidence

Composed locally with public-beta at 6a408cc85 without conflicts. CI and unit checks pass.

@Lightheartdevs

Copy link
Copy Markdown
Collaborator

Thanks for this contribution. public-beta was promoted into main on 2026-09-24 and no longer receives changes, so we're closing pull requests that target it. This isn't a judgment on the change itself. If it's still needed, please rebase onto main and open a focused PR. See #7253 for details and the contribution policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants