Repository navigation
fix(token-spy): reset the assessed local session - #4583
Merged
gabsprogrammer merged 1 commit intoSep 13, 2026
Merged
gabsprogrammer merged 1 commit into
gabsprogrammer merged 1 commit into
Conversation
This was referenced Sep 12, 2026
0xacee
marked this pull request as ready for review
September 13, 2026 04:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters: The local-agent poller assesses the newest JSONL history by modification time, then calls a reset helper that independently selects the largest file. With an older large conversation and a newer over-limit one, it deletes the older conversation and leaves the assessed problem running.
Carry the assessed session ID into the local poller's reset operation. If that file has disappeared, stop without selecting another history. Record the cooldown only after an actual reset. Manual/proxy reset selection keeps its existing largest-session behavior; the public session-status response gains no internal selection metadata.
Validation:
Overlap check: searched live/all-state titles and changed files. Inspected #1923 (shell session-manager active-ID extraction), #2803 (atomic index writes) and #2691 (I/O exception types). #4569 bounds local scanner memory. None binds the poller's reset target to the history it assessed.
AI assistance: implemented and tested with Codex. Review required before merge: independent review of destructive session operations and live validation. Deletion tests touch synthetic temporary files only. This binds selection by session ID; it does not add filesystem locking or replace the separate atomic index-write proposals.
Combined validation: c08b6695ff14 on public-beta base 9fc9f61. Token Spy: 64 passed, 1 skipped, including assessed-target deletion and event-loop responsiveness together.
Merge guidance: tested Token Spy main.py order is #4561, #4569, #4583, #4634, #4640. The #4583/#4634 poller conflict must retain await asyncio.to_thread for status and reset, include_session_id=True on assessment, session_id=status["_reset_session_id"] on deletion, and cooldown updates only after action == "killed".