Repository navigation
perf(token-spy): bound memory for local session status polls - #4569
Merged
gabsprogrammer merged 1 commit intoSep 13, 2026
Merged
gabsprogrammer merged 1 commit into
gabsprogrammer merged 1 commit into
Conversation
This was referenced Sep 12, 2026
0xacee
marked this pull request as ready for review
September 13, 2026 04:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters: A local-model agent with a long JSONL conversation causes every authenticated session-status poll to load the entire history into memory. A 12,000-turn fixture (~13 MB) allocated 13,724,595 bytes in the existing HTTP fallback. Read the file incrementally while preserving turn counts, tool counts, history characters, malformed-line handling, file size and recommendations.
Evidence and validation:
AI assistance: implemented and validated with Codex. Local HTTP tests use synthetic session files and no live agent. Review required before merge: independent review of session monitoring, which feeds automatic reset decisions.
Combined validation: c08b6695ff14 on public-beta base 9fc9f61. Token Spy: 64 passed, 1 skipped, including the public HTTP memory-budget regression.
Merge guidance: tested Token Spy main.py order is #4561, #4569, #4583, #4634, #4640. The #4583/#4634 poller conflict must retain await asyncio.to_thread for status and reset, include_session_id=True on assessment, session_id=status["_reset_session_id"] on deletion, and cooldown updates only after action == "killed".