Repository navigation
fix(invites): keep deadlines active through JSON body reads - #4353
Merged
gabsprogrammer merged 1 commit intoSep 13, 2026
Merged
Conversation
tang-vu
marked this pull request as ready for review
September 11, 2026 16:47
This was referenced Sep 14, 2026
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
The Owner access request helper cleared its 8-second deadline as soon as fetch returned headers. A stalled list, owner-status, generation or QR JSON body could then leave loading/submitting active indefinitely. A rendered regression reproduces the list case: HTTP 200 arrives, JSON never completes, and the page cannot refresh.
Read the body under the original AbortController deadline. Preserve the callers' response status and deferred JSON-error handling using a small result adapter. Timeout messages request a list refresh before another action; nothing is automatically retried.
Overlap check
Searched open/closed Invites.jsx PRs. Inspected #3038 (isolate owner-status failures): it changes Promise.all to allSettled, not the fetch/body deadline. #3833 ignores obsolete refreshes, #3846 filters inventory, and #2327 handles clipboard. None covers the body phase. The helper remains compatible with their existing ok/status/json callers.
Validation
npx vitest run src/pages/InvitesBodyDeadline.test.jsx src/pages/Invites.test.jsx: 7 passed, including explicit refresh recovery, existing revocation, generation payloads, and QR flows.A timeout does not prove a server mutation failed. The UI asks for reconciliation and performs no retry; the existing server remains authoritative. Tests simulate the browser's body-read AbortError path, with no live card issued or revoked. Revert restores the headers-only deadline.
Batch integration receipt
Validated with the other 19 public-beta PRs on integration commit ce0d0132, based on upstream f5f49b7. All 20 patches compose without conflicts in creation order; no new PR requires another to fix its own behavior. For shared files, use #4325 before #4327 and #4339 before #4356 as the tested order.
Latest candidate CI: 32 successful checks, 4 skipped. Draft status on filesystem/authorization changes is retained for independent human review despite green CI.