Repository navigation
Conversation
This was referenced Sep 15, 2026
This was referenced Sep 16, 2026
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
The owner-card and guest-invite overlays declare
aria-modalbut leave the page behind them interactive. In Chromium, Tab reaches background refresh/create actions while a credential dialog is open. The generated-card/invite overlay also ignores Escape and does not return focus to its opener.Use one native modal dialog frame for both creation forms and generated results. Native modality contains interaction; cancellation handles Escape consistently, and closing restores the actual owner/guest opener even after the create-to-result transition. Keep the existing constrained, scrolling panel and typography when moving the role from a styled div to a native dialog.
Validation
Overlap check
Live open/closed title and changed-file search found #1839 (Escape in creation overlays only), #4353 (JSON body deadlines), #3833 (refresh ordering), #3038 (owner-status failures), #3846 (inventory filtering), and #2327 (clipboard compatibility). None establishes native modality or completes generated-result keyboard dismissal. No change to token generation, revocation, request ownership, or clipboard logic.
Independent branch from freshly fetched
upstream/public-beta,d49ad4bbc760be319de7f4c9b9a93b1f18fe3922. No semantic dependency or required merge order with these request/filter/clipboard PRs; shared Invites imports/markup may require normal rebase reconciliation. No combined-runtime claim for those unrelated changes.Risk and review
Client interaction change only. Independent review and Safari/Firefox, assistive-technology and real print validation remain pending; Chromium checks do not stand in for those gates. Browser fixtures use dummy URLs and create no live credentials. Rollback restores the previous div overlays.
AI-assisted implementation and browser investigation. Ready for review; this is not approval to merge.
Current validation
At the 2026-09-14 audit, head
b22f4a48061bd80cfdc021ea8bb682ae4b60653ehas 32 successful and 4 skipped hosted checks, with no failed or pending checks. Independent human review and the declared deployed/platform checks remain merge gates.Local synthetic integration head
e8f982f09ba4c714ee2a65cb6867ea3e4328bfdecombines the 30 September 14 candidates. Its complete frontend suite passes 144 files / 1,125 tests, and its production build passes.