Skip to content

Revert latest xs-dev commit#860

Merged
jensen-yan merged 1 commit into
xs-devfrom
revert-xs-dev-latest
May 22, 2026
Merged

Revert latest xs-dev commit#860
jensen-yan merged 1 commit into
xs-devfrom
revert-xs-dev-latest

Conversation

@XXtaoo
Copy link
Copy Markdown
Collaborator

@XXtaoo XXtaoo commented May 22, 2026

Reverts the latest squash-merged commit on xs-dev.

Summary by CodeRabbit

  • Chores
    • Updated ideal_kmhv3 example configuration with zero-latency memory timing and disabled prefetch buffer support.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

📝 Walkthrough

Walkthrough

Configuration parameters in the ideal KM-HV3 example are tuned: L2-to-bus timing latencies are zeroed, ahead-cycle hinting is removed, and prefetch buffer enablement is disabled by default.

Changes

Ideal KM-HV3 Configuration Tuning

Layer / File(s) Summary
L2 bus timing parameters
configs/example/idealkmhv3.py
Lines 118–120 set forward_latency, response_latency, and hint_wakeup_ahead_cycles to 0 for the tol2bus configuration in the L2 bus wrapper loop.
Prefetch buffer default
configs/example/idealkmhv3.py
Line 147 changes args.enable_pf_buffer from True to False, disabling prefetch buffer support by default in this example configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • OpenXiangShan/GEM5#859: Modifies the same configuration parameters in idealkmhv3.py but with opposite value adjustments for timing and prefetch settings.

Suggested reviewers

  • happy-lx
  • Ergou-ren

Poem

🐰 The buses hush, no latencies delay,
Prefetch buffers fade and slip away,
An ideal speed, pristine and pure—
Zero-cycle dreams, forever sure! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Revert latest xs-dev commit' accurately describes the main change—reverting a recent commit on the xs-dev branch as confirmed by the PR objectives.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-xs-dev-latest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@XXtaoo XXtaoo requested a review from jensen-yan May 22, 2026 07:05
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@configs/example/idealkmhv3.py`:
- Around line 146-147: The comment above args.enable_pf_buffer is misleading: it
currently reads "Enable prefetch buffers for all hardware prefetchers in this
config." but the code sets args.enable_pf_buffer = False; update the comment to
reflect the disabled state (e.g., "Disable prefetch buffers for all hardware
prefetchers in this config." or similar) so the comment matches the behavior of
args.enable_pf_buffer.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e10c2f53-f7ef-4162-a090-1697e4b1f73b

📥 Commits

Reviewing files that changed from the base of the PR and between 587fe8e and 2f492c0.

📒 Files selected for processing (1)
  • configs/example/idealkmhv3.py

Comment thread configs/example/idealkmhv3.py
@jensen-yan jensen-yan merged commit 7930d36 into xs-dev May 22, 2026
2 checks passed
@jensen-yan jensen-yan deleted the revert-xs-dev-latest branch May 22, 2026 07:16
@github-actions
Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.3130 -
This PR 2.3130 ➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants