Microtage abtb align#845
Conversation
Change-Id: I7a203669c0830276e3585e10c931308575304fa9
Change-Id: I6472b4c5ad5c9ed8c793a4d6b069d4d792541d94
Change-Id: I3267bb3466f1b922280f7b34ecc627f6ec093882
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request disables two branch predictor subcomponents (ABTB and microtage) within the DecoupledBPUWithBTB configuration path in the KMH V3 system parameters. Their Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17f6da93e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cpu.branchPred.abtb.enabled = False | ||
| cpu.branchPred.microtage.enabled = False |
There was a problem hiding this comment.
Keep ABTB and MicroTAGE enabled by default
This change hard-disables both abtb and microtage for every DecoupledBPUWithBTB run in kmhv3.py, which silently changes the default Kunminghu v3 frontend behavior and can significantly skew branch-prediction-sensitive performance experiments. Because there is no new CLI/config switch to opt back in, users running the standard config cannot reproduce prior baselines or compare against the intended composed predictor stack.
Useful? React with 👍 / 👎.
🚀 Coremark Smoke Test Results
✅ Difftest smoke test passed! |
|
[Generated by GEM5 Performance Robot] Align BTB PerformanceOverall Score
[Generated by GEM5 Performance Robot] Align BTB PerformanceOverall Score
|
test close microTage and test close ABTB
Summary by CodeRabbit