arch-riscv: Add an assert for vector splitting.#840
Conversation
Change-Id: I2aae4e4c13f0c528354d9e404bd857f42175ddb9
|
🚀 RVV Performance test triggered: spec06int-rvv-0.8c |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdded a runtime assertion in the ChangesVector Arithmetic Validation
Vector Design Documentation (Chinese)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds a debug-time invariant check in the RISC-V vector arithmetic ISA template to validate assumptions about how many micro-ops are created when vector instructions are split based on LMUL.
Changes:
- Add an
assertto ensurenum_microopsis either 1 or an even number before generating micro-ops.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🚀 Coremark Smoke Test Results
✅ Difftest smoke test passed! |
Change-Id: I8216f2832fc528cd3bb07af9b04fde6d494761a9
🚀 Coremark Smoke Test Results
✅ Difftest smoke test passed! |
Change-Id: I2aae4e4c13f0c528354d9e404bd857f42175ddb9
Summary by CodeRabbit
Chores
Documentation