Skip to content

Tracking legacy resolve train feature performance#823

Open
Yakkhini wants to merge 2 commits into
xs-devfrom
ideal-resolve-evaluation
Open

Tracking legacy resolve train feature performance#823
Yakkhini wants to merge 2 commits into
xs-devfrom
ideal-resolve-evaluation

Conversation

@Yakkhini
Copy link
Copy Markdown
Collaborator

@Yakkhini Yakkhini commented Apr 10, 2026

Change-Id: I9bb3f593b1e247977b371103fdd5ebb66821fcaa

Summary by CodeRabbit

  • Chores
    • Adjusted branch predictor configuration: enabled resolved-update behavior for specific predictor subcomponents in one example configuration.
    • Relaxed forcing of resolved-update flags in another example configuration so those flags are configurable rather than always forced on.

Change-Id: I9bb3f593b1e247977b371103fdd5ebb66821fcaa
@github-actions
Copy link
Copy Markdown

🚀 Performance test triggered: gcc12-spec06-0.8c

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d8b8dfb8-72d5-41d8-a9ad-7352e0bc1841

📥 Commits

Reviewing files that changed from the base of the PR and between ad8ab1c and ea101a2.

📒 Files selected for processing (1)
  • configs/example/kmhv3.py
💤 Files with no reviewable changes (1)
  • configs/example/kmhv3.py

📝 Walkthrough

Walkthrough

Configuration changes to KMHv3 examples: configs/example/idealkmhv3.py now sets resolvedUpdate = True for three branch predictor subcomponents when DecoupledBPUWithBTB is used; configs/example/kmhv3.py removes forced resolvedUpdate = True assignments for those same subcomponents in the same branch.

Changes

Cohort / File(s) Summary
Ideal KMHv3 config
configs/example/idealkmhv3.py
When args.bp_type == DecoupledBPUWithBTB, set resolvedUpdate = True for cpu.branchPred.mbtb, cpu.branchPred.tage, and cpu.branchPred.ittage.
KMHv3 config
configs/example/kmhv3.py
Removed forcing resolvedUpdate = True for cpu.branchPred.mbtb, cpu.branchPred.tage, and cpu.branchPred.ittage in the DecoupledBPUWithBTB configuration path.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

align-kmhv3

Suggested reviewers

  • jensen-yan
  • happy-lx

Poem

🐰 In configs gentle as a breeze,
Three predictors learn with ease,
Resolved at last, they hop in tune,
Fields aligned beneath the moon,
A tiny commit — a grateful snooze.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The PR title 'Tracking legacy resolve train feature performance' is vague and does not clearly describe the actual changes, which involve enabling/disabling resolvedUpdate flags in branch predictor configurations. Replace with a more specific title that clearly indicates the primary change, such as 'Enable resolvedUpdate in ideal configuration for resolve train evaluation' or 'Disable resolvedUpdate on kmhv3 branch predictor configuration'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ideal-resolve-evaluation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.2713 -
This PR 2.2713 ➡️ 0.0000 (0.00%)

✅ Difftest smoke test passed!

@XiangShanRobot
Copy link
Copy Markdown

[Generated by GEM5 Performance Robot]
commit: ad8ab1c
workflow: On-Demand SPEC Test (Tier 1.5)

Ideal BTB Performance

Overall Score

PR Master Diff(%)
Score 20.38 21.69 -6.05 🔴

@Yakkhini Yakkhini mentioned this pull request Apr 10, 2026
@Yakkhini Yakkhini changed the title misc: enable resovle train on idealkmhv3 for evaluation Tracking legacy resolve train feature performance Apr 10, 2026
Change-Id: Ife75832bb85e5742ce3959b14eb9f32264036f70
@Yakkhini
Copy link
Copy Markdown
Collaborator Author

Yakkhini commented Apr 10, 2026

Disable resolve train on kmhv3 evaluation: https://github.com/OpenXiangShan/GEM5/actions/runs/24229545486

@github-actions
Copy link
Copy Markdown

🚀 Coremark Smoke Test Results

Branch IPC Change
Base (xs-dev) 2.2713 -
This PR 2.2953 📈 +0.0240 (+1.06%)

✅ Difftest smoke test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants