[ginaxu1]

Summary

Follow-up to #112 / closes #115.

schemaHasConditionalRequired now walks the whole schema (properties, items, then/else, etc.), follows local $refs into $defs / definitions, and caches the result per schema object in a WeakMap. Property-level enum oneOf that only lists const options stays on the fast path; branches that add required or further conditionals do not.

Type of change

• Bug fix (completes unreleased fix(jsonforms-renderers): show required asterisk for conditionally required fields #112 fast-path gap)

Release notes

N/A — covered in #112's release notes (nested / $ref conditionals). Use skip-changelog on this PR.

Test plan

• Nested if/then under properties enables the AJV-backed asterisk path
• Local $ref into $defs with a conditional is detected
• Self-referential $ref does not loop
• Enum-only property oneOf still skips AJV when there is no conditional required
• Existing root-level allOf/if/then behaviour from fix(jsonforms-renderers): show required asterisk for conditionally required fields #112 unchanged

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 49d2eca7-0c66-4fbc-9fd3-e3ac992fea4b

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sthanikan2000]

The scan looks right: I ran the suite and probed it against AJV, and the #115 example works end to end. Three things:

1. The base is #112's branch, so Packages CI hasn't run. After #112 squash-merges, please git rebase --onto main and confirm CI is green. Please run pnpm lint too; I saw possible no-unnecessary-type-assertion at required.ts lines 28, 108 and 115, which I couldn't confirm locally.
2. It has both Type/Improvement and Type/Bug. This completes unreleased work, so I'd use skip-changelog and mention nested/$ref in #112's Release notes.
3. Please change the title scope to jsonforms-renderers. Optional: add a test for the self-referential $ref guard.

[ginaxu1]

@sthanikan2000 Thanks — addressed what we can before #112 merges:

1. Lint: fixed the three no-unnecessary-type-assertion hits in required.ts (43ed744). pnpm lint / eslint is clean on that file; tests pass including a self-referential $ref guard. Rebase onto main + Packages CI will happen after fix(jsonforms-renderers): show required asterisk for conditionally required fields #112 squash-merges (still open).
2. Labels: removed Type/Improvement and Type/Bug, added skip-changelog. Nested/$ref called out in fix(jsonforms-renderers): show required asterisk for conditionally required fields #112's Release notes.
3. Title scope is now jsonforms-renderers.

[ginaxu1]

Addressed the non-blocking dependencies follow-up from #112: isPathRequiredBySchema now matches AJV errors with keyword dependencies (property-array form) as well as required. Schema-form dependencies already surfaced as nested required errors. Covered with a unit test.

[sthanikan2000]

Re-checked on the rebased head. Through the real controls, nested if/then, a conditional behind a local $ref, and property-array dependencies all show the * when the condition holds and not otherwise. The schema-form dependencies claim in your comment is also correct. 587 tests pass, type-check is clean, and CI is green now that it targets main. Approving.

Non-blocking: the description still says "Stacked on #112 … rebase after #112 squash-merges", and the test-plan boxes are unchecked. Worth cleaning up before merge.