[ginaxu1]

Summary

Split out of #112 so release notes can list this separately from the conditional-required asterisk work.

NumberControl reads minimum / exclusiveMinimum / multipleOf for min / step. When the bound is >= 0, it blocks - / + / e / E on keydown and paste. getErrorMessage rewrites exclusiveMinimum / minimum / multipleOf AJV messages into clearer wording.

Type of change

• Bug fix

Changes made

• NumberControl: min / step from schema; block signed/exponent keys and pastes when bound >= 0
• getErrorMessage: clearer exclusiveMinimum / minimum / multipleOf messages
• Playground number fixture: add an assessedAmount field with exclusiveMinimum: 0 and multipleOf: 0.01

Testing

• pnpm test in jsonforms-renderers
• Number fixture: assessed amount rejects - / + / e and shows readable constraint errors

Release notes

Number fields with a minimum/exclusiveMinimum >= 0 no longer accept -, +, e or E, and use min/step from the schema. Error messages now read "X must be greater than 0" instead of "must be > 0".

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 072f36d6-16a6-42cd-956c-00b0194527fc

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sthanikan2000]

LGTM. Tests pass, and the key/paste test fails when onKeyDown/onPaste are removed, so it pins the behaviour. The release note is accurate.

Merge note: #112 and #119 both add NumberControl.test.tsx, so the second one to merge gets one add/add conflict. Keep main's file and add this PR's it to its describe, using renderForm({ reviewOutcome: 'approve' }). I tried #112 + #117 + #119 together and all 578 tests pass. Suggested order: #112, #117, then #119.

[ginaxu1]

Rebased onto main after #112. PTAL @sthanikan2000

[sthanikan2000]

Re-checked after the rebase onto main. Your conflict resolution matches what I suggested: the test file keeps main's asterisk test and adds the key/paste one. The new afterEach debounce flush looks right. I ran the file five times with no flakiness, and the key/paste test still fails when onKeyDown/onPaste are removed. The full suite passes (586) and type-check is clean. Approving.