Skip to content

docs: shorten npm READMEs and ship LICENSE with each package - #103

Merged
sthanikan2000 merged 1 commit into
mainfrom
docs/npm-readmes-and-license
Oct 10, 2026
Merged

sthanikan2000 merged 1 commit into
mainfrom
docs/npm-readmes-and-license

Conversation

@sthanikan2000

Copy link
Copy Markdown
Member

Summary

The published tarballs ship no licence text: the only LICENSE is at the repo root, and files is a whitelist, so npm doesn't pick it up. The READMEs npm shows are also long (auth) or stale (jsonforms-renderers). This ships a LICENSE with each package and cuts each README down to what npmjs.com needs, pointing here for the rest.

Type of change

  • Bug fix
  • New feature
  • Improvement to an existing feature
  • Breaking change (consumers must change their code)
  • Docs, tests, refactor or CI only

Changes made

  • Add packages/auth/LICENSE and packages/jsonforms-renderers/LICENSE, copied from OpenNSW/core. Fill in the copyright holder in the root LICENSE, which still had the Apache [yyyy] [name of copyright owner] placeholder (Copyright (c) 2026 Lanka Software Foundation, as in core).
  • Shorten both package READMEs to: what it is, install, a minimal example, and absolute links to the details in this repo (relative links break on npmjs.com, and docs/ isn't published).
  • jsonforms-renderers README: fix the example, which imported a default export that doesn't exist (the package exports radixRenderers, plus @opennsw/jsonforms-renderers/styles.css); drop the control list (7 of many), the relative src/… links and the lint command (the package has no lint script).
  • Move the detailed auth guide to packages/auth/docs/usage.md (not shipped).

Testing

  • npm pack --dry-run --ignore-scripts now lists LICENSE and README.md for both packages (before, no LICENSE)
  • Every link in both READMEs is absolute
  • The three LICENSE files are byte-identical to core's (same SHA-256)
  • prettier --check is clean

Release notes

Each package ships its LICENSE and the shorter README with its next published version. No API or behaviour change.

@sthanikan2000 sthanikan2000 added Package/jsonforms-renderers Changes to packages/jsonforms-renderers Package/auth Changes to packages/auth labels Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ee2f4ffb-0a5a-44ac-8088-2f68b872a0a8

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ginaxu1 ginaxu1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

The published tarballs had no licence text: the only LICENSE lived at the
repo root and `files` is a whitelist. They also showed long or stale
READMEs.

- Add a LICENSE to packages/auth and packages/jsonforms-renderers, copied
  from OpenNSW/core, so npm ships it. Fill in the copyright holder in the
  root LICENSE (it still had the Apache boilerplate placeholder).
- Shorten each package README to what it is, install, a minimal example and
  absolute links to the details in this repo, since that is what npmjs.com
  shows. The jsonforms-renderers README imported a default export that does
  not exist; it now uses `radixRenderers` and the styles.css entry.
- Move the detailed auth guide to packages/auth/docs/usage.md (not shipped).
@sthanikan2000
sthanikan2000 force-pushed the docs/npm-readmes-and-license branch from d44c2e9 to 70c7112 Compare October 10, 2026 04:36
@sthanikan2000
sthanikan2000 merged commit 8a9ec00 into main Oct 10, 2026
3 checks passed
WebCooper added a commit to WebCooper/ui-packages that referenced this pull request Oct 10, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
@sthanikan2000 sthanikan2000 added skip-changelog Leave this PR out of the release notes Type/Task General task or chore and removed skip-changelog Leave this PR out of the release notes labels Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Package/auth Changes to packages/auth Package/jsonforms-renderers Changes to packages/jsonforms-renderers Type/Task General task or chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants