Skip to content

Job splitter consolidate - #1126

Open
tbaudier wants to merge 13 commits into
masterfrom
job_splitter_consolidate
Open

tbaudier wants to merge 13 commits into
masterfrom
job_splitter_consolidate

Conversation

@tbaudier

@tbaudier tbaudier commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Serialize RepeatParametrisedVolume to be able to save it in .json the repeated volume.
We can test the splitting with actors/test036_adder_depth_param.py

@tbaudier

tbaudier commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

For biaising actor attributes and parrallel world you can test the splitting with geometry/test054e_multi_parallel_worlds_mt.py

@tbaudier

tbaudier commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor Author

For boolean_volume, can be tested with geometry/test016_bool_volumes.py
For blurring attributes in digitizer, can be tested with actors/test049_pet_digit_blurring_v3.py
For spatial blurring attributes in digitizer, can be tested with actors/test094_truncatedGaussian.py

@tbaudier
tbaudier force-pushed the job_splitter_consolidate branch 3 times, most recently from 049dea9 to 1498d71 Compare September 15, 2026 11:50
Comment thread docs/source/user_guide/user_guide_how_to_convert_example_1.rst Outdated
Comment thread opengate/jobs.py Outdated
"repeated_volume_name": (
None,
{"doc": "Name of the repeated volume."},
),

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set repeated_volume into user_info_defaults or in to_dict() function instead of repeated_volume_name

Comment thread opengate/actors/biasingactors.py Outdated
Comment thread opengate/actors/digitizers.py Outdated
Comment thread slurm.json
For RepeatParametrisedVolume, the repeated_volume was not serialized. So it was not possible to create the RepeatParametrisedVolume from a json
Now, save the repeated_volume_name and add the reference in volumes.py to be sure to have the link to the repeated_volume
self.volume_manager could be None so the except with ErrorKey fails to catch it
Now, we are still able to create the volume
@tbaudier
tbaudier force-pushed the job_splitter_consolidate branch 4 times, most recently from 8399047 to 23f0035 Compare October 6, 2026 09:16
Before if both were set, it returned an error
But after an export to json, both are set because previously computed
So now, we only set the sigma and if the fwhm is set by the user, with the setter and getter method it's automatically convert to sigma
Check if numpy input, to convert it to int, float, bool for the serialization
@tbaudier
tbaudier force-pushed the job_splitter_consolidate branch from 8b5b5db to 9d2e1f3 Compare October 7, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant