Repository navigation
Conversation
Contributor
Author
|
For biaising actor attributes and parrallel world you can test the splitting with geometry/test054e_multi_parallel_worlds_mt.py |
Contributor
Author
|
For boolean_volume, can be tested with geometry/test016_bool_volumes.py |
tbaudier
force-pushed
the
job_splitter_consolidate
branch
3 times, most recently
from
September 15, 2026 11:50
049dea9 to
1498d71
Compare
tbaudier
commented
Sep 18, 2026
tbaudier
commented
Sep 18, 2026
tbaudier
commented
Sep 18, 2026
| "repeated_volume_name": ( | ||
| None, | ||
| {"doc": "Name of the repeated volume."}, | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
set repeated_volume into user_info_defaults or in to_dict() function instead of repeated_volume_name
tbaudier
commented
Sep 18, 2026
tbaudier
commented
Sep 18, 2026
tbaudier
commented
Sep 18, 2026
For RepeatParametrisedVolume, the repeated_volume was not serialized. So it was not possible to create the RepeatParametrisedVolume from a json Now, save the repeated_volume_name and add the reference in volumes.py to be sure to have the link to the repeated_volume
…r available to export to json files
self.volume_manager could be None so the except with ErrorKey fails to catch it Now, we are still able to create the volume
tbaudier
force-pushed
the
job_splitter_consolidate
branch
4 times, most recently
from
October 6, 2026 09:16
8399047 to
23f0035
Compare
Before if both were set, it returned an error But after an export to json, both are set because previously computed So now, we only set the sigma and if the fwhm is set by the user, with the setter and getter method it's automatically convert to sigma
Check if numpy input, to convert it to int, float, bool for the serialization
tbaudier
force-pushed
the
job_splitter_consolidate
branch
from
October 7, 2026 08:35
8b5b5db to
9d2e1f3
Compare
… installed during CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serialize RepeatParametrisedVolume to be able to save it in .json the repeated volume.
We can test the splitting with actors/test036_adder_depth_param.py