Repository navigation
Conversation
For RepeatParametrisedVolume, the repeated_volume was not serialized. So it was not possible to create the RepeatParametrisedVolume from a json Now, save the repeated_volume_name and add the reference in volumes.py to be sure to have the link to the repeated_volume
…r available to export to json files
self.volume_manager could be None so the except with ErrorKey fails to catch it Now, we are still able to create the volume
Before if both were set, it returned an error But after an export to json, both are set because previously computed So now, we only set the sigma and if the fwhm is set by the user, with the setter and getter method it's automatically convert to sigma
Check if numpy input, to convert it to int, float, bool for the serialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After PR #1126