Repository navigation
fix(staff-ui): render dashboard image as background on 1.2 - #203
Closed
asmitonweb wants to merge 1 commit into
Closed
asmitonweb wants to merge 1 commit into
asmitonweb wants to merge 1 commit into
Conversation
Contributor
|
@asmitonweb FYI, The Staff UI home page has two distinct visual elements.
In this pr, the background pattern has been removed, and the dashboard illustration is being used as the page background. This does not align with the intended design of platform. |
|
@shibu-narayanan, as part of the registry implementation, our requirement is to have a full sized background image rather than a background pattern. is it ok if we make the corresponding change to have the following options in the theme
Currently this functionality does not exist and hence we updated the dashboard illustration. CC: @asmitonweb, @Q-Niranjan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An uploaded
dashboard_imagerenders as a full-width illustration below the dashboard search bar. A photograph grows with page width, pushes content below the viewport and leaves the patterned background behind the cards.Use a configured image as a decorative, centered cover background behind the cards/search controls, with a light theme-coloured overlay. It does not add document height or receive pointer events. Preserve the existing pattern and people illustration when no custom image is configured, and retain the
1.2branch's responsive widths and foreground overflow behavior.This PR is based directly on the
1.2release branch at5f828d2, which contains the source revision of the currently consumed1.2.2-rc.544platform image (323a9829). It contains one dashboard-component change and nodevelop-only commits. It replaces closed PR #200, whose original head was based ondevelop.Validation:
1.2.2-rc.544's OCI source revision (323a9829) is an ancestor of the target release branch. The PR contains one commit and changes onlyui/staff-ui/src/app/[locale]/page.tsxrelative to1.2.git diff --checkpassed. Resolved the port against the release branch while retaining its responsive content widths and unclipped foreground controls.developbaseline, not this release-line port.npm cicould not complete: this workstation's npm policy disables remote-tarball dependencies, and1.2already depends on@openg2p/notificationfrom a GitHub tarball. No policy or dependency pins were changed. The failed installation left no runnable local build/lint/component dependencies, so those checks have not been rerun on this port. Upstream UI CI must validate the release-line build before merge.The existing theme setting is reused; no schema, API, dependency or version-pin changes are included. This changes the presentation of configured dashboard images from illustrations to backgrounds; cropping follows viewport aspect ratio. No Farmer Registry repository changes or deployments are included.