Repository navigation
fix(ui): resolve intake uploads and shared document widgets - #204
Closed
asmitonweb wants to merge 2 commits into
Closed
asmitonweb wants to merge 2 commits into
asmitonweb wants to merge 2 commits into
Conversation
|
@shibu-narayanan , can you please review the PR and see if it can be merged. CC: @asmitonweb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intake currently uploads only
_direct_fileentries and does not replace file values with their uploaded document IDs. Profile photos can be omitted, and incomplete upload responses can be followed by a section save. File references in read-only tables also render as IDs/objects rather than usable document links.This change moves the generic behavior needed by downstream registry overlays into the
1.2staff UI and widget sources:clearFileWhenHiddenfor dialog file fields.showInfo/showMetadataheader options and preserve existing uppercase acronyms such as GC/EC in generated titles.No Farmer field names, derived certificate flags, compiled-bundle patches, backend API changes or deployment pins are introduced. Background layout remains separate in #203.
Validation:
ui/ui-widgets:npm test(16 passing),npm run type-check,npm run build.git diff --check.7934c93: widget install/type-check/all 16 tests/build and the full staff UI install/Next.js production build. The existing notification dependency remains unchanged. Local staff UI installation is still restricted by the workstation'sEALLOWREMOTEpolicy; the GitHub build completed independently.action_requiredon commit7934c93; fork PR workflows require maintainer approval upstream.CI follow-up: the initial fork Build & Publish run failed workflow validation before starting jobs because the reusable image/chart jobs request
packages: writeand the caller inherited read-only defaults. The caller now explicitly grantscontents: read/packages: write. Publishing is gated to non-fork repositories, while UI CI runs build-only checks on fork pushes withcontents: read. Actionlint passed for both changed workflows. No repository-wide permission setting or publishing credential was changed.Release/integration: the existing widgets publication workflow on
1.2publishes the package, updates the exact staff UI dependency pin and dispatches Build & Publish. Downstream overlays must remain until the resulting shared image and required metadata options pass intake-to-register acceptance. This PR does not remove a Farmer image or change its Registry Platform version.Implementation and acceptance notes:
ui/INTAKE_DOCUMENTS.md.