Skip to content

Fix traefik Dockerfile detection of image type #3990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jalexanderqed wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix traefik Dockerfile detection of image type #3990

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9732a14
Refine comments and enhance package manager checks
jalexanderqed Oct 2, 2026
3abcbf0
Remove extra line
jalexanderqed Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions openc3-traefik/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,23 @@ ENV IMAGE_GROUP=openc3
ENV USER_ID=1001
ENV GROUP_ID=1001

# On docker.io (alpine) create the non-root user and upgrade with apk.
# On the alpine image, create the non-root user and upgrade with apk.
# The ironbank image already has uid 1001, but it is only rebuilt on RedHat's
# schedule, so pull the RPM security fixes released since with dnf.
RUN if [[ $OPENC3_DEPENDENCY_REGISTRY == 'docker.io' ]]; then \
# schedule, so pull the RPM security fixes released since with dnf. Detect
# which package manager is present rather than inferring from the registry
# name, so mirrors of the public alpine image still take the apk branch.
RUN if command -v apk >/dev/null 2>&1; then \
addgroup -g ${GROUP_ID} -S ${IMAGE_GROUP}; \
adduser -u ${USER_ID} -G ${IMAGE_GROUP} -s /bin/ash -S ${IMAGE_USER}; \
apk update && apk upgrade; \
else \
elif command -v dnf >/dev/null 2>&1; then \
dnf -y upgrade && \
dnf clean all && \
rm -rf /var/cache/dnf; \
else \
echo "no supported package manager (apk/dnf) found" >&2; exit 1; \
fi

# Switch to user
USER ${USER_ID}
COPY --chown=1001:1001 --chmod=755 ./entrypoint.sh /entrypoint.sh
COPY --chown=1001:1001 --chmod=755 ./entrypoint.sh /entrypoint.sh
Loading