Repository navigation
Fix traefik Dockerfile detection of image type - #3990
Open
jalexanderqed wants to merge 2 commits into
Open
jalexanderqed wants to merge 2 commits into
jalexanderqed wants to merge 2 commits into
Conversation
Update traefik Dockerfile to detect the image type based on the available package manager. This avoids an issue we experienced due to using a mirrored registry instead of docker.io
|
jalexanderqed
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Updated traefik Dockerfile to detect the image type based on the available package manager.
Why it changed
This avoids an issue our company experienced due to using a mirrored registry instead of docker.io
Testing strategy
Tested the matching change internally using our internal Docker image build pipeline.
Review notes
Detecting the type of image (Alpine vs. Red Hat) based on the OPENC3_DEPENDENCY_REGISTRY does not work if the OPENC3_DEPENDENCY_REGISTRY is different for any other reason. In our case, it was different because we use an internal registry that mirrors docker.io. We were still using the Alpine image, but the existing check in the Dockerfile assumed we were using an Ironbank Red Hat image.