Skip to content

fix(admin): wait for version history info before modified plugin dialog #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmthomas wants to merge 1 commit into
base: fix_modified_plugin_dialog_upgrade
Choose a base branch
from
+6 −3
Open

fix(admin): wait for version history info before modified plugin dialog #3988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions openc3-cosmos-init/plugins/packages/openc3-vue-common/src/tools/admin/tabs/PluginsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,9 @@ export default {

// Detect whether the Enterprise Version History backend is enabled
// (OPENC3_VERSION_HISTORY_DIR set) so per-plugin Export/Import History
// actions can be shown.
Api.get('/openc3-api/info')
// actions can be shown. The promise is kept so the upgrade flow can wait
// for it before opening ModifiedPluginDialog, which picks its flow once.
this.infoLoaded = Api.get('/openc3-api/info')
.then((response) => {
this.scriptVersionsEnabled = !!response.data?.script_versions
})
Expand Down Expand Up @@ -413,13 +414,15 @@ export default {
this.file = undefined
})
},
pluginCallback: function (pluginHash) {
pluginCallback: async function (pluginHash) {
this.showPluginDialog = false
if (this.currentPlugin !== null) {
pluginHash['name'] = this.currentPlugin
}
this.pluginHashTmp = pluginHash
if (this.isModified(this.currentPlugin)) {
// The upgrade flow depends on scriptVersionsEnabled
await this.infoLoaded
this.pluginDelete = false
this.showModifiedPluginDialog = true
} else {
Expand Down
Loading