Conversation
ModifiedPluginDialog picks its upgrade flow once at creation, so opening it before /openc3-api/info returned could skip versioning and report no conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix_modified_plugin_dialog_upgrade #3988 +/- ##
======================================================================
+ Coverage 80.12% 80.15% +0.02%
======================================================================
Files 901 901
Lines 68374 68374
Branches 2650 2650
======================================================================
+ Hits 54784 54802 +18
+ Misses 12924 12907 -17
+ Partials 666 665 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The synchronization fix is correct; only a deterministic regression test is missing.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
No blocking issues. 1 test-coverage nit.
Ensures modified-plugin upgrades wait for Version History capability detection before selecting the upgrade flow.
Changes:
- Retains the
/openc3-api/inforequest promise. - Awaits capability detection before opening
ModifiedPluginDialog.
| File | Description |
|---|---|
PluginsTab.vue |
Synchronizes modified-plugin upgrade flow with Version History detection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| this.pluginHashTmp = pluginHash | ||
| if (this.isModified(this.currentPlugin)) { | ||
| // The upgrade flow depends on scriptVersionsEnabled | ||
| await this.infoLoaded |
ModifiedPluginDialog picks its upgrade flow once at creation, so opening it before /openc3-api/info returned could skip versioning and report no conflicts. Extremely unlikely in practice due to user clicking but potentially triggerable in automated testing.