fix(comms): make ComQueue comStatusIn blocking so the one-shot arming status can't be dropped (#494)

[Mikefly123]

Fixes #494.

What

One-line FPP change in the fprime fork, delivered as a submodule pin bump (03c645123 on fix/comqueue-blocking-comstatus-main, based directly on main's current pin 8a62e455a):

-      async input port comStatusIn: Fw.SuccessCondition
+      async input port comStatusIn: Fw.SuccessCondition block

Why

See #494 for the full trace. Summary: the com-status arming protocol is one-shot — the single SUCCESS emitted at startup by ComAggregator::preamble() shares ComQueue's IPC message queue with the boot event burst on comPacketQueueIn. If the queue is momentarily full, the generated handler FW_ASSERTs (invisibly, with CONFIG_LOG=n) and the arming message is lost. ComQueue then sits in WAITING forever: no telemetry, no events, no command acks — on every boot of that binary, for both the UART and LoRa stacks. The race outcome is deterministic per build, so any change to startup workload (components, events, init timing — e.g. PR #472's littlefs mount) can flip a passing build into a permanently silent one.

block makes the low-rate status sender wait for a queue slot instead: delivery guaranteed, zero RAM, no deadlock exposure (the comQueue thread never blocks back toward the aggregator; at most one frame is in flight per status).

Why not just deepen the queue

Tried first: QueueSizes.comQueue at 48/64/100 all exhaust the malloc arena at boot (BufferManager's ~27KB contiguous configComponents allocation returns NULL → usage fault). Heap slack with littlefs on is <8KB. Depth also only re-wins the race probabilistically; block removes it categorically.

Verification (bench, two V5e units)

Binary	Board 1	Board 2
pre-fix (littlefs present)	FAIL every boot — comQueue.m_state == WAITING, GDB-traced enqueue → PriorityQueue FULL → assert hook	identical failure signature
with this fix	PASS 3× incl. cold reset — SequenceNumberGet/OpCodeCompleted round-trips	PASS 2×, telemetry channels flowing

Note this PR fixes the latent protocol bug on main itself; main currently happens to win the boot race, so there is no observable behavior change expected — the regression only manifests when combined with boot-workload changes like the #472 keystore. Suggested review focus: the blocking-semantics deadlock argument in the fork commit message.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WpBURCutAx8281i59nj6fo

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7d1aa4c7-8cbe-46c8-870c-6340f08ca6ab

📥 Commits

Reviewing files that changed from the base of the PR and between f7ee882 and 8b81a2c.

📒 Files selected for processing (1)

• lib/fprime

---

📝 Walkthrough

Summary by CodeRabbit

• Chores
  • Updated the bundled FPrime component to a newer version.
  • No user-facing feature or behavior changes are included in this update.
  • The update maintains existing functionality while incorporating the latest available component changes.

Walkthrough

The pull request updates the lib/fprime submodule reference from commit 8a62e455a90b6d4f498c332d45d65a2a819988d8 to commit 03c6451237d4442248703947693c1985a1948e88. No local source declarations change.

Changes

F´prime Submodule Update

Layer / File(s)	Summary
Update F´prime reference lib/fprime	The submodule pointer changes to commit 03c6451237d4442248703947693c1985a1948e88.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A rabbit checks the pointer bright,
One F´prime commit comes in sight.
The source stays still today,
While the newer pin leads the way.
Hop, hop, update complete!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the blocking comStatusIn change that fixes the one-shot arming race.
Description check	✅ Passed	The description explains the cause, fix, rejected alternative, linked issue, and verification results, despite omitting some template sections.
Linked Issues check	✅ Passed	The submodule pin includes the blocking comStatusIn fix required by issue #494 to prevent ComQueue from remaining in WAITING.
Out of Scope Changes check	✅ Passed	The only change is the fprime submodule pin, which directly implements the linked issue objective.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nateinaction]

This worked for me.

[nateinaction]

Oh wait. It looks like I did not use this.