Skip to content

Throw when transcript exceeds a certain size #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flin-8 wants to merge 1 commit into from
Closed

Throw when transcript exceeds a certain size #2046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions source/Calamari.AiAgent/ClaudeCodeBehaviour/ClaudeCodeCliRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ public async Task<string> RunAsync(ClaudeCommandArgsBuilder argsBuilder,

if (File.Exists(verboseLogPath))
{
ThrowIfTranscriptTooBig(verboseLogPath);

@zentron zentron Jun 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This throws once the task has completed already right?
Wonder if we can keep track of this as we append the transcript and throw mid-execution, just to avoid this being a way to hide something malicious

@flin-8 flin-8 Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep track as in audit this?


log.WriteServiceMessage(new ServiceMessage(ClaudeCodeServiceMessages.Transcript.Name, new Dictionary<string, string>()
{
{ClaudeCodeServiceMessages.Transcript.TranscriptAttribute, await File.ReadAllTextAsync(verboseLogPath, cancellationToken)},
Expand All @@ -71,6 +73,14 @@ public async Task<string> RunAsync(ClaudeCommandArgsBuilder argsBuilder,
return responseBuilder.ToString();
}

static void ThrowIfTranscriptTooBig(string verboseLogPath)
{
const long maxTranscriptSize = 1L * 1024 * 1024 * 1024;
var transcriptSize = new FileInfo(verboseLogPath).Length;
if (transcriptSize > maxTranscriptSize)
throw new InvalidOperationException($"Claude agent transcript log is too large ({transcriptSize:N0} bytes). The 1 GB limit was exceeded.");
}

async Task ProcessError(Process process)
{
var buffer = new char[1024];
Expand Down