Throw when transcript exceeds a certain size#2046
Closed
flin-8 wants to merge 1 commit into
Closed
Conversation
zentron
requested changes
Jun 28, 2026
|
|
||
| if (File.Exists(verboseLogPath)) | ||
| { | ||
| ThrowIfTranscriptTooBig(verboseLogPath); |
Contributor
There was a problem hiding this comment.
This throws once the task has completed already right?
Wonder if we can keep track of this as we append the transcript and throw mid-execution, just to avoid this being a way to hide something malicious
Contributor
Author
There was a problem hiding this comment.
Keep track as in audit this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a guard for now so we don't send huge transcripts and overload Server's storage
Resolves MD-2102: Implement a hard limit to prevent runaway storage costs