fix(ci): add CRITICAL severity box fallback to learn page script - #362
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
ritiksah141
previously approved these changes
Sep 27, 2026
ritiksah141
left a comment
ritiksah141
left a comment
Collaborator
There was a problem hiding this comment.
Nice catch. Approving it
Signed-off-by: Vishnu Ajith <27vishnu07@gmail.com>
Vishnu2707
force-pushed
the
fix/learn-page-critical-severity-box
branch
from
September 27, 2026 21:09
b65616c to
23d6dfb
Compare
TFT444
approved these changes
Sep 27, 2026
ritiksah141
approved these changes
Sep 27, 2026
parthrohit22
pushed a commit
to parthrohit22/openshield
that referenced
this pull request
Sep 27, 2026
Resolve modify/delete conflict on .github/scripts/update_learn_page.py: OWASP#362 refined the script's patterns, but this PR replaces the static Learn page and its update script with build-time stats in website/src/pages/ learn.astro (which already renders the CRITICAL severity box), so the deletion is kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MDxfYrq7uecZbnEkEesWbJ
parthrohit22
added a commit
to parthrohit22/openshield
that referenced
this pull request
Sep 27, 2026
Resolve the modify/delete conflict on .github/scripts/update_learn_page.py. OWASP#362 refined that script, but this PR replaces the static Learn page and its update script with build-time stats in website/src/pages/learn.astro, which already renders the CRITICAL severity box, so the deletion is kept. Signed-off-by: parthrohit22 <parthrohit60@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learn page script was missing a fallback to insert the CRITICAL severity box if it's not already present in docs/learn/index.html (only HIGH/MEDIUM/LOW existed as fixed patterns before). Adds that, plus a small cleanup replacing the local
sevalias withseveritiesdirectly for clarity.Small follow-on to #350, rebased on top of it.