Skip to content

Fix: derive OSVersion and OSBuild from OSName in Default parameter set #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhilipSiborgs wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −0
Open

Fix: derive OSVersion and OSBuild from OSName in Default parameter set #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Public/Start-OSDCloud.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,19 @@ function Start-OSDCloud {
}
$OSName = $Global:StartOSDCloud.OSName
Write-Host -ForegroundColor DarkGray "[$(Get-Date -format G)] OSName is set to $($Global:StartOSDCloud.OSName)"
#=================================================
# Derive OSVersion and OSBuild from OSName so that downstream
# logic (notably OSDCloudUSB OS caching in OSDCloud.ps1) works
# identically to the Legacy parameter set. Without this, users
# starting with -OSName get $null for OSVersion/OSBuild, which
# silently disables the automatic OS cache to USB.
#=================================================
if ($Global:StartOSDCloud.OSName -match '^(Windows \d+)\s+(\S+)\s+x64$') {
$Global:StartOSDCloud.OSVersion = $Matches[1]
$Global:StartOSDCloud.OSBuild = $Matches[2]
Write-Host -ForegroundColor DarkGray "[$(Get-Date -format G)] OSVersion derived from OSName: $($Global:StartOSDCloud.OSVersion)"
Write-Host -ForegroundColor DarkGray "[$(Get-Date -format G)] OSBuild derived from OSName: $($Global:StartOSDCloud.OSBuild)"
}
}
elseif ($PSCmdlet.ParameterSetName -eq 'Legacy') {
#=================================================
Expand Down